Fix memset call in basic_concepts user guide - #2368
Merged
Merged
Conversation
The example on line 195 called mem_s.memset(value=...), but _Memory.memset's parameter is named val. It also had a stray extra quote in ord(b"-""). Correct both so the snippet runs.
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
August 19, 2026 11:53
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Collaborator
|
Coverage is 74.462% — fix-basic-concepts-memset-doc into master. No base build found for |
ndgrigorian
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a broken example in the "Basic Concepts" user guide.
The snippet on
basic_concepts.rst:195called:Two problems:
_Memory.memset's parameter is namedval, notvalue, so the keyword argument raisesTypeError.ord(b"-"")has a stray extra double-quote, which is aSyntaxError.Corrected to:
Documentation-only change; no code or behavior is affected.