Migrate host_task object management to a thread pool based approach - #2359
Open
ndgrigorian wants to merge 5 commits into
Open
Migrate host_task object management to a thread pool based approach#2359ndgrigorian wants to merge 5 commits into
host_task object management to a thread pool based approach#2359ndgrigorian wants to merge 5 commits into
Conversation
ndgrigorian
requested review from
antonwolfy and
vlad-perevezentsev
as code owners
August 10, 2026 18:16
Inspired by comment in: AdaptiveCpp/AdaptiveCpp#1915 we move away from use of host_task, which enables compatibility with AdaptiveCpp
ndgrigorian
force-pushed
the
feature/drop-host-task-object-management
branch
from
August 10, 2026 18:17
c41755c to
bbf7d44
Compare
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/2359/index.html |
Collaborator
|
coverage: 74.501% (+0.04%) from 74.462% — feature/drop-host-task-object-management into master |
antonwolfy
reviewed
Aug 17, 2026
Also change pool getter to avoid any dpctl4pybind11 including extensions from having their own thread pools
antonwolfy
reviewed
Aug 19, 2026
| } // end of namespace detail | ||
|
|
||
| template <std::size_t num> | ||
| sycl::event keep_args_alive(sycl::queue &q, |
Collaborator
There was a problem hiding this comment.
@vlad-perevezentsev, is that intended in dpnp we are using the local copy of that function dpnp::utils::keep_args_alive instead of dpctl vendored function?
Btw, due to that there is no real impact on dpnp due to that dpctl migration change, except new deprecation wanrnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by comment in: AdaptiveCpp/AdaptiveCpp#1915
we move away from use of
host_task, which enables compatibility with AdaptiveCpp, and fixes long-standing undefined behavior of callingsycl::freefrom within ahost_task. Thehost_taskdecrementing the refcount would cause theUSMDeleterto be called in its scope, which is undefined behavior under the SYCL spec