Docs note and checkModules test for qualified vs stacked parameters#2449
Open
ChristophyBarth wants to merge 1 commit into
Open
Docs note and checkModules test for qualified vs stacked parameters#2449ChristophyBarth wants to merge 1 commit into
ChristophyBarth wants to merge 1 commit into
Conversation
Follow-up to 4fae618 (InsertKoinIO#2370, InsertKoinIO#2408, also reported as InsertKoinIO#2406, InsertKoinIO#2435), which made qualified requests resolve from definitions instead of stacked parameters. - docs: note in injection-parameters.md that parameter graph resolution only applies to unqualified requests - koin-test: regression test that checkKoinModules resolves a named String single from the module instead of handing get(named(...)) the MockParameter default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to 4fae618 (#2370, #2408, also reported in #2406 and #2435), which made qualified requests resolve from definitions instead of stacked parameters. Replaces #2440, which made the same resolver change independently.
This PR carries over the two pieces that are not yet on
main:injection-parameters.mdclarifying that graph resolution of injected parameters only applies to unqualified requests;get(named(...))always resolves from module definitions.CheckModulesTestcovering thecheckKoinModulespath, where aget(named("env"))dependency used to receive the MockParameter default""instead of the named single. The existing tests from 4fae618 cover direct resolution but not the check/verify path.Verified with
:core:koin-test:jvmTest --tests CheckModulesTeston currentmain.