chore: Remove unused field in User for better implementation on iOS#175
Open
tevincent wants to merge 1 commit into
Open
chore: Remove unused field in User for better implementation on iOS#175tevincent wants to merge 1 commit into
tevincent wants to merge 1 commit into
Conversation
Contributor
|
This PR/issue depends on:
|
There was a problem hiding this comment.
Pull request overview
This PR trims the Kotlin Multiplatform (migration) user preference models to remove fields that are no longer needed, simplifying the exported iOS surface and the Android↔shared model mapping.
Changes:
- Remove many properties from
SharedSecurity, keeping onlyscoreanddateLastChangedPassword. - Remove
language,country, andtimezonefrom migrationPreferences. - Update
MigrationUtilsmappings accordingly (drop the removed preference/security conversions).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| multiplatform-lib/src/commonMain/kotlin/models/migration/user/preferences/security/SharedSecurity.kt | Shrinks the exported migration security model to only the fields used by the authenticator. |
| multiplatform-lib/src/commonMain/kotlin/models/migration/user/preferences/Preferences.kt | Removes unused preference fields from the exported migration preferences model. |
| app/src/main/kotlin/com/infomaniak/auth/utils/MigrationUtils.kt | Aligns Android↔shared conversions with the reduced migration model schema. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tevincent
force-pushed
the
simplify-user-profile
branch
from
dffe0ac to
4e5d11f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on Infomaniak/android-core#764