Repository navigation
Conversation
When text is present in the address bar but does not match the format of a domain, pressing Ctrl + Enter will autocomplete it to end up being a proper URL including the protocol and the toplevel domain (TLD) parts. For instance, when pressing Ctrl + Enter in these cases: - "domain" -> becomes "https://www.domain.com" - "node.js" -> becomes "https://www.node.js.com" - "domain.com" -> stays as "https://domain.com" - "https://domain" -> stays as "https://domain" This matches what mainstream browsers already do.
The tests load the public suffix list from src/test-wig-utils.dat, which the test build passes to wig-utils.c as WIG_PSL_FILE, so their results do not depend on the version of the list installed on the system. This adds a new file src/test-wig-utils.c and integrates it with CI.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches the behaviour of mainstream browsers where e.g. you just type "foobar" in
the address bar, press Ctrl + Enter, and get "https://www.foobar.com" loaded.