Modernize AnnouncementForm to ipl based RepositoryForm - #5546
Open
jrauh01 wants to merge 3 commits into
Open
Conversation
jrauh01
force-pushed
the
modernize-announcement-form
branch
3 times, most recently
from
July 17, 2026 09:01
4c2d91f to
c086a73
Compare
lippserd
force-pushed
the
modernize-repository-form
branch
from
July 21, 2026 07:34
4137360 to
133a75e
Compare
jrauh01
force-pushed
the
modernize-repository-form
branch
5 times, most recently
from
July 27, 2026 14:32
0dc7389 to
ef94b62
Compare
jrauh01
force-pushed
the
modernize-announcement-form
branch
from
August 6, 2026 14:58
c086a73 to
40e55c3
Compare
Now we don't have to use view scripts anymore. Use `setTitleTab()` to set the tab and the title respectively. This differs from the earlier behavior where the title was always `Announcements`.
Covers all three repository modes and the timestamp conversion `fetchEntry()` adds on top of `RepositoryForm`. The repository is backed by an in-memory `Config` whose `saveIni()` is a no-op, so inserts, updates and deletions can be asserted on the config itself without touching the filesystem. Two behaviors are pinned deliberately. Updating an announcement reassigns it to the editing user, because the disabled author element is never submitted back and the stored one is only pre-filled when the form has not been sent. This has been the case since the Zend implementation. Start and end now default to tomorrow and the day after, which the move to `localDateTime` turned from mere placeholders into actual values.
jrauh01
force-pushed
the
modernize-announcement-form
branch
from
August 10, 2026 13:42
40e55c3 to
2b1cd4e
Compare
jrauh01
marked this pull request as ready for review
August 10, 2026 13:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the announcement form off the Zend
Icinga\Forms\RepositoryFormonto the ipl-basedIcinga\Web\Form\RepositoryForm, movesAnnouncementsControllertoCompatController, and adds test coverage. The$Identifierproperty and corresponding getter are narrowed to?string.Each action builds its form inline, sets the CSRF counter-measure id from the session, wires
ON_SUBMIT/ON_ERRORfor the notifications, and renders viaaddContent(). Tabs come fromaddTitleTab().Change in behavior
StartandEndare now pre-filled.They were
'placeholder' => new DateTime('tomorrow')on the ZenddateTimePicker, and<input type="datetime-local">ignoresplaceholder, so the hint had to become a realvalueor disappear. Submitting without touching either field now succeeds and yields tomorrow through the day after, where it previously failed validation.