Allow to manage and subscribe to incidents - #1392
Merged
Merged
Conversation
BastianLedererIcinga
force-pushed
the
feature/incidents
branch
13 times, most recently
from
July 15, 2026 06:13
b67ee1d to
d467e78
Compare
Contributor
|
Please mention the required PR Icinga/icinga-notifications-web#472 in the description. |
sukhwinder33445
suggested changes
Jul 16, 2026
sukhwinder33445
left a comment
sukhwinder33445
left a comment
Contributor
There was a problem hiding this comment.
Please fix the alignment of the new ack badge.
Contributor
|
One more thing I noticed: once you subscribe to and then unsubscribe from an incident in the incident detail view, subscribing again is not possible and throws an error, because the unsubscribe removes the incident_contact DB entry entirely. |
Contributor
Author
As discussed in person, this an unrelated bug, caused by the |
BastianLedererIcinga
force-pushed
the
feature/incidents
branch
from
July 17, 2026 06:18
55cbf41 to
243c34d
Compare
sukhwinder33445
approved these changes
Jul 17, 2026
nilmerg
requested changes
Jul 31, 2026
nilmerg
left a comment
nilmerg
left a comment
Member
There was a problem hiding this comment.
Looking at this I noticed a flaw in my previous idea how the new component is integrated here. It relies on a few presumptions that are either incompatible or simply wrong:
- The user acknowledging needs a matching notifications contact
- This is not always true and we have no idea to identify this as intentional or not, an additional permission should solve this
- The acknowledgement form still allows to declare an expiry time
- But there's no way for Icinga DB to remove a manager, Icinga/icinga-notifications#478
- The acknowledgement form still allows to disable the sticky flag
- Let's hide this option for users that have the new manage permission and are a contact in notifications
- Enabling icinga notifications web does not mean it's configured, but this should be a requirement and be easy to answer to decide what to offer
- The module being enabled is not enough, db web knows about a working notifications component, so this should be the condition instead
- incident is already an outdated term so I don't want to see it here. It is also of no meaning to users which have no access to the configuration UI anyway, so we should rather focus on proper representation what the effect of acknowledge now is and what subscribe means compared to the legacy notifications feature. A seamless integration so to say, without the need for the user to know anything about Icinga Notifications.
nilmerg
reviewed
Aug 3, 2026
nilmerg
requested changes
Aug 7, 2026
Base automatically changed from
use-cached-results-when-processing-command-actions
to
main
August 11, 2026 14:33
nilmerg
added a commit
that referenced
this pull request
Aug 11, 2026
This effectively makes it impossible to accidentally issue the query over and over. refs #1392
nilmerg
force-pushed
the
feature/incidents
branch
3 times, most recently
from
August 11, 2026 14:53
5c7bd3d to
0d9cb9f
Compare
nilmerg
requested changes
Aug 12, 2026
Contributor
Author
|
The added When testing subscribe and unsubscribe in a detail view, the subscribe button may not change to unsubscribe. This is a bug in |
BastianLedererIcinga
force-pushed
the
feature/incidents
branch
from
August 18, 2026 09:31
0c54b10 to
99d53b1
Compare
nilmerg
requested changes
Aug 18, 2026
Member
|
Please also extend |
nilmerg
requested changes
Aug 26, 2026
nilmerg
requested changes
Aug 27, 2026
nilmerg
left a comment
nilmerg
left a comment
Member
There was a problem hiding this comment.
Still have to test this, though. 😩 Didn't look at the UI in detail as well yet.
nilmerg
requested changes
Aug 28, 2026
nilmerg
reviewed
Aug 28, 2026
nilmerg
requested changes
Sep 2, 2026
nilmerg
requested changes
Sep 3, 2026
nilmerg
left a comment
nilmerg
left a comment
Member
There was a problem hiding this comment.
One, very small, thing left. You can directly sqash and rebase now.
Add a subscribe/unsubscribe option to `QuickActions` and `MultiSelectQuickActions`, and adjust the exitsing acknowledge/unacknowledge actions to also manage/unmanage.
Show subscribers and recipeints in a new section, highlighting the manager with a redisigned ack-badge. Rename the exitsing `Notifications` section to `Configured Contacts` to avoid confusion.
BastianLedererIcinga
force-pushed
the
feature/incidents
branch
from
September 3, 2026 12:58
beae7dc to
b8a11f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #1358
requires Icinga/icinga-notifications-web#545
Add a new
Subscribebutton toQuickActions, to that allows to subscribe to the incident matching the Host/Service.The existing Acknowledge/Unacknowledge option also serves as manage/unmanage of the matching incident.
Users that have no notification contact configured will see an error message when trying to subscribe, and a warning when acknowledging.
A new
Notification Recipientssection is added to both Host- and Sevicedetail, showing the current recipients and subscribers. The manager is highlighted with the redesigned ack badge suggested in #1358 (comment).