Handle UUID's correctly for both DBMs - #547
Merged
Merged
Conversation
yhabteab
force-pushed
the
handle-uuid-binary-values
branch
5 times, most recently
from
August 26, 2026 08:36
ac5dc52 to
782b0d1
Compare
nilmerg
requested changes
Aug 26, 2026
yhabteab
force-pushed
the
handle-uuid-binary-values
branch
from
August 26, 2026 12:34
782b0d1 to
ec2745c
Compare
Member
Author
|
Changed as requested but all the tests fail because of this dependency. |
nilmerg
requested changes
Aug 26, 2026
yhabteab
force-pushed
the
handle-uuid-binary-values
branch
from
August 26, 2026 13:00
ec2745c to
f23814b
Compare
nilmerg
reviewed
Aug 26, 2026
nilmerg
left a comment
Member
There was a problem hiding this comment.
Still need to test, but code looks fine.
yhabteab
force-pushed
the
handle-uuid-binary-values
branch
2 times, most recently
from
August 27, 2026 07:52
39766b2 to
deb08a0
Compare
nilmerg
requested changes
Aug 27, 2026
yhabteab
force-pushed
the
handle-uuid-binary-values
branch
from
August 27, 2026 08:58
deb08a0 to
2a42e76
Compare
Member
Author
|
I've addressed all your requested changes apart from #547 (comment) because it doesn't make any sense to me. |
yhabteab
force-pushed
the
handle-uuid-binary-values
branch
from
August 27, 2026 09:18
2a42e76 to
4e2b784
Compare
nilmerg
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for UUID binary and text format in all UI activities involving UUIDs. For this to work, I've introduced a new
UUIDbehavior in IPL orm that is used to automatically convert UUIDs between binary and text formats for MySQL but is a no-op for PostgreSQL as PDO treats the binary format as a string when not explicitly told otherwise via thePDO::PARAM_LOBparameter. Since I've no way to do that parameter binding in all possible cases, I've decided to leave PostgreSQL as-is.I've also updated the API handlers to partially use the Models instead of raw SQL queries via ipl SQL, so that the UUID can be used in those cases as well. The API handlers are still using raw SQL queries in some places, but I've added an explicit conversion to binary format for those cases, so that the UUIDTransformer is not needed there.
Lastly, I've extended the
ObjectSuggestionsCursorclass to require the column name for which the suggestions are being generated, and the registered model behaviors the column belongs to, so that it also applies the behaviors, including the UUID behavior to the suggestions.Context
external_uuidfields & change type tobinary(16)in MySQL icinga-notifications#496