Properly handle soft-deleted rows - #522
Merged
Merged
Conversation
nilmerg
force-pushed
the
feature/properly-handle-soft-deleted-rows
branch
from
July 24, 2026 14:51
a762b09 to
b674c6c
Compare
nilmerg
force-pushed
the
feature/properly-handle-soft-deleted-rows
branch
from
July 27, 2026 13:20
b674c6c to
2a57161
Compare
nilmerg
force-pushed
the
feature/properly-handle-soft-deleted-rows
branch
2 times, most recently
from
July 27, 2026 13:55
131df5b to
1025658
Compare
nilmerg
force-pushed
the
feature/properly-handle-soft-deleted-rows
branch
from
July 27, 2026 14:17
1025658 to
f633892
Compare
nilmerg
force-pushed
the
feature/properly-handle-soft-deleted-rows
branch
from
July 28, 2026 11:08
f633892 to
eb12c73
Compare
nilmerg
force-pushed
the
feature/properly-handle-soft-deleted-rows
branch
3 times, most recently
from
August 4, 2026 09:55
8d02488 to
1fd8ab1
Compare
nilmerg
marked this pull request as ready for review
August 4, 2026 09:56
BastianLedererIcinga
requested changes
Aug 5, 2026
BastianLedererIcinga
left a comment
BastianLedererIcinga
left a comment
Contributor
There was a problem hiding this comment.
Apart from the deprecation warning everything worked fine while testing and the changes look good.
nilmerg
force-pushed
the
feature/properly-handle-soft-deleted-rows
branch
from
August 5, 2026 09:56
1fd8ab1 to
e28da7f
Compare
BastianLedererIcinga
previously approved these changes
Aug 5, 2026
nilmerg
force-pushed
the
feature/properly-handle-soft-deleted-rows
branch
2 times, most recently
from
August 6, 2026 11:28
d6b0fc3 to
039bf40
Compare
Member
Author
|
the latest two commits contain new changes |
BastianLedererIcinga
previously approved these changes
Aug 10, 2026
They now expect the ORM to restrict access to deleted rows automatically and bypass this restriction by issuing raw sql queries to verify successful deletions.
- all models now use a visibility filter to limit access to non-deleted rows - all queries made implicitly rely on this and don't filter explicitly
Also drops some invalid cases, as only contacts can manage/subscribe.
nilmerg
force-pushed
the
feature/properly-handle-soft-deleted-rows
branch
from
August 11, 2026 14:07
81c2f68 to
2b7d235
Compare
BastianLedererIcinga
approved these changes
Aug 11, 2026
github-project-automation
Bot
moved this from In progress
to Done
in Icinga Notifications 1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a proper way to hide deleted entities automatically. The previous work-around only affected a query's base table and thus didn't restrict joins the same way. Now, joins are covered as well, as are any sub-queries made by the ORM. And that is the only behavior related change: Queries made by ipl-sql are not automatically filtered anymore.
Related changes are introduced as well:
LEFTjoin types to relations that were always meant to have itNULLrequires Icinga/ipl-orm#165