Skip to content

Add list and detail view for sent notifications - #512

Merged
nilmerg merged 3 commits into
mainfrom
add-list-and-detail-view-of-sent-notifications
Sep 4, 2026
Merged

Add list and detail view for sent notifications#512
nilmerg merged 3 commits into
mainfrom
add-list-and-detail-view-of-sent-notifications

Conversation

@sukhwinder33445

@sukhwinder33445 sukhwinder33445 commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR implements the Notification History list and per-notification detail view.

Changes:

  • Added NotificationHistory model + renderer + detail widget, with new controllers for list/detail views.
  • Extended incident detail with a Notification History tab and scoped search suggestions.
  • Added supporting enums, condition description helper, styling, and PHPUnit tests.

resolves #475

require:

@sukhwinder33445 sukhwinder33445 self-assigned this Jul 15, 2026
@cla-bot cla-bot Bot added the cla/signed CLA is signed by all contributors of a PR label Jul 15, 2026
@sukhwinder33445
sukhwinder33445 force-pushed the add-list-and-detail-view-of-sent-notifications branch 6 times, most recently from cb46a62 to 7c7a8e7 Compare July 21, 2026 12:23
@sukhwinder33445
sukhwinder33445 requested a review from Copilot July 21, 2026 12:24

This comment was marked as resolved.

Sign in to view

@sukhwinder33445
sukhwinder33445 force-pushed the add-list-and-detail-view-of-sent-notifications branch 2 times, most recently from 0d12e38 to 5b985d7 Compare July 21, 2026 14:06
@sukhwinder33445

sukhwinder33445 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Failing tests will pass once #518 has been merged.

@sukhwinder33445
sukhwinder33445 force-pushed the add-list-and-detail-view-of-sent-notifications branch 2 times, most recently from 2e42a41 to cc3f767 Compare July 21, 2026 14:57
@sukhwinder33445
sukhwinder33445 requested a review from Copilot July 21, 2026 15:00

This comment was marked as resolved.

Sign in to view

@sukhwinder33445
sukhwinder33445 force-pushed the add-list-and-detail-view-of-sent-notifications branch 7 times, most recently from b10faf4 to d0f39a3 Compare July 27, 2026 14:35
@sukhwinder33445
sukhwinder33445 force-pushed the add-list-and-detail-view-of-sent-notifications branch 4 times, most recently from cd01600 to 49d332a Compare July 30, 2026 14:29
@sukhwinder33445

sukhwinder33445 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

This is how the list and detail view currently looks like:

Screenshot 2026-07-30 at 16 51 00

@BastianLedererIcinga
BastianLedererIcinga force-pushed the add-list-and-detail-view-of-sent-notifications branch 4 times, most recently from 6a03e71 to f547941 Compare August 11, 2026 13:57
@BastianLedererIcinga
BastianLedererIcinga force-pushed the add-list-and-detail-view-of-sent-notifications branch from f547941 to 897a7ec Compare August 18, 2026 11:38
@BastianLedererIcinga
BastianLedererIcinga force-pushed the add-list-and-detail-view-of-sent-notifications branch 2 times, most recently from 3b4b6ee to db3497f Compare September 2, 2026 09:30
@BastianLedererIcinga
BastianLedererIcinga changed the base branch from main to multiple-related-sources September 2, 2026 09:30
@BastianLedererIcinga

BastianLedererIcinga commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

This is how the list and detail view currently looks like:

Screenshot 2026-07-30 at 16 51 00

I will move all trigger chain related code into a draft PR because the daemon does not fully support it yet and the linked issue never mentioned it in the first place.

Base automatically changed from multiple-related-sources to main September 2, 2026 11:11
@BastianLedererIcinga
BastianLedererIcinga force-pushed the add-list-and-detail-view-of-sent-notifications branch 3 times, most recently from 4bd6244 to a3c57a3 Compare September 3, 2026 07:28
@yhabteab

yhabteab commented Sep 4, 2026

Copy link
Copy Markdown
Member

Since I've heard a lot about I'm being too lazy to comment something here, well, here're my two cents about UI related stuff that I think should be changed. It's not a change request, so you can ignore this if you don't want to.

The message was rendered at the top of the notification history detail view, which looked odd to me since it pushed all the other important info down or up when being expanded/collapsed. Though, you've already changed that yestarday, so looked to me now and also consistent to how it's rendered in the incident detail view.

The recipients and the channel in the detail view aren't clickable while the subscribers/managers in the incident detail view are clickable. In the below screenshot, it would be actually nice if one could click on the recipient and the contact group redirecting the respecitive views. Same also with the channel.

Bildschirmfoto 2026-09-04 um 09 42 37

nilmerg
nilmerg requested changes Sep 4, 2026
View reviewed changes
Comment thread library/Notifications/Widget/ItemList/ObjectList.php Outdated
Comment thread library/Notifications/Model/NotificationHistory.php
Comment thread configuration.php Outdated
Comment thread configuration.php Outdated
Comment thread library/Notifications/Widget/Detail/NotificationHistoryDetail.php Outdated
Comment thread application/controllers/IncidentController.php Outdated
Comment thread configuration.php Outdated
Comment thread application/controllers/NotificationHistoryController.php Outdated
Comment thread application/controllers/NotificationHistoryController.php Outdated
Comment thread library/Notifications/Common/EscalationConditionDescriber.php Outdated
@BastianLedererIcinga
BastianLedererIcinga force-pushed the add-list-and-detail-view-of-sent-notifications branch from a3c57a3 to c32f41b Compare September 4, 2026 14:12
sukhwinder33445 and others added 2 commits September 4, 2026 17:06
@sukhwinder33445 @BastianLedererIcinga @nilmerg
Introduce new NotificationHistoryList and detail-view
9fe6e1f 
Co-Authored-By: Bastian Lederer <bastian.lederer@icinga.com>
@sukhwinder33445 @BastianLedererIcinga @nilmerg
Introduce Notification History tab in incident detail view
e2bbeaa 
`ObjectSuggestions`: Apply base filter to suggest only
current-incident-based suggestions.

Co-Authored-By: Bastian Lederer <bastian.lederer@icinga.com>
@nilmerg
nilmerg force-pushed the add-list-and-detail-view-of-sent-notifications branch from c32f41b to a456c81 Compare September 4, 2026 15:13
@BastianLedererIcinga @sukhwinder33445 @nilmerg
IncidentHistory: cast type and relate notification history
a243b9d 
Replaces the string comparisons in `IncidentHistoryRenderer` with the new
`IncidentHistoryType` enum and describes unnamed escalations by their
condition.

Co-Authored-By: Sukhwinder Dhillon <sukhwinder.dhillon@icinga.com>
@nilmerg
nilmerg force-pushed the add-list-and-detail-view-of-sent-notifications branch from a456c81 to a243b9d Compare September 4, 2026 15:15
nilmerg
nilmerg approved these changes Sep 4, 2026
View reviewed changes

@nilmerg nilmerg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed a few things myself again and squashed.

@nilmerg
nilmerg merged commit 7d54b1c into main Sep 4, 2026
13 checks passed
@nilmerg
nilmerg deleted the add-list-and-detail-view-of-sent-notifications branch September 4, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@nilmerg nilmerg nilmerg approved these changes

Assignees

@BastianLedererIcinga BastianLedererIcinga

Labels

cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a view for sent notifications

5 participants

@sukhwinder33445 @BastianLedererIcinga @yhabteab @nilmerg