Skip to content

Check that contracted axes match in contract #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtfishman merged 1 commit into from
Aug 10, 2026
Merged

Check that contracted axes match in contract #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "TensorAlgebra"
uuid = "68bd88dc-f39d-4e12-b2ca-f046b68fcc6a"
version = "0.19.1"
version = "0.19.2"
authors = ["ITensor developers <support@itensor.org> and contributors"]

[workspace]
Expand Down
18 changes: 17 additions & 1 deletion src/contract/allocate_output.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,25 @@ function check_input(
a1, perm1_codomain, perm1_domain,
a2, perm2_codomain, perm2_domain
)
# TODO: FIXME: Check that contracted axes match.
check_biperm(a1, perm1_codomain, perm1_domain)
check_biperm(a2, perm2_codomain, perm2_domain)
# The contracted axes of `a1` (its domain) pair with the contracted axes of `a2` (its codomain),
# and each pair must be a dual pair: `dual(ax1) == ax2`. `dual` falls back to the identity for
# plain ranges, so this reduces to `ax1 == ax2` for non-graded arrays.
length(perm1_domain) == length(perm2_codomain) || throw(
ArgumentError(
"Number of contracted axes do not match: `a1` has $(length(perm1_domain)), `a2` has $(length(perm2_codomain))"
)
)
for (i, j) in zip(perm1_domain, perm2_codomain)
ax1 = axes(a1, i)
ax2 = axes(a2, j)
dual(ax1) == ax2 || throw(
ArgumentError(
"Contracted axes do not match: `axes(a1, $i) = $ax1` and `axes(a2, $j) = $ax2`"
)
)
end
return nothing
end

Expand Down