Skip to content

Fix non-contiguous non-Hermitian correlations - #221

Merged
mtfishman merged 2 commits into
mainfrom
mf/fix-issue-220-mps-typo
May 9, 2026
Merged

Fix non-contiguous non-Hermitian correlations#221
mtfishman merged 2 commits into
mainfrom
mf/fix-issue-220-mps-typo

Conversation

@mtfishman

@mtfishman mtfishman commented May 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Fix a typo in the lower-triangle correlation_matrix update for non-Hermitian bosonic correlations over non-contiguous site selections.
  • Add regression coverage comparing a non-contiguous sites result against the corresponding full correlation matrix entries.
  • Bump the patch version for the library change.

Fixes #220.

@mtfishman
mtfishman marked this pull request as ready for review May 9, 2026 00:32
@codecov

codecov Bot commented May 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.13%. Comparing base (2523743) to head (1a9b3ec).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   89.96%   90.13%   +0.16%     
==========================================
  Files          52       52              
  Lines        3577     3577              
==========================================
+ Hits         3218     3224       +6     
+ Misses        359      353       -6     
Flag Coverage Δ
docs 18.14% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman
mtfishman enabled auto-merge (squash) May 9, 2026 01:10
@mtfishman
mtfishman merged commit 712f18f into main May 9, 2026
18 checks passed
@mtfishman
mtfishman deleted the mf/fix-issue-220-mps-typo branch May 9, 2026 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Typo in mps.jl

1 participant