Extend TensorAlgebra's dual/isdual instead of defining GradedArrays' own - #219
Merged
Conversation
…ys' own ## Summary GradedArrays now extends the `dual` and `isdual` generics owned by TensorAlgebra (added in ITensor/TensorAlgebra.jl#214) rather than defining its own copies, and re-exports them. Its `SectorRange`, `SectorOneTo`, and `GradedOneTo` methods become `TensorAlgebra.dual` / `TensorAlgebra.isdual` overloads. The `dual` on a raw TensorKitSectors sector moves to `TensorAlgebraTensorKitSectorsExt` (ITensor/TensorAlgebra.jl#215) and `dual` on a TensorKit `ElementarySpace` moves to `TensorAlgebraTensorKitExt`, so both are dropped here. Bumps the TensorAlgebra compat floor to 0.17.9.
mtfishman
enabled auto-merge (squash)
July 24, 2026 14:41
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
==========================================
- Coverage 84.78% 84.76% -0.02%
==========================================
Files 28 28
Lines 2083 2081 -2
==========================================
- Hits 1766 1764 -2
Misses 317 317
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GradedArrays now extends the
dualandisdualgenerics owned by TensorAlgebra (added in ITensor/TensorAlgebra.jl#214) rather than defining its own copies, and re-exports them. ItsSectorRange,SectorOneTo, andGradedOneTomethods becomeTensorAlgebra.dual/TensorAlgebra.isdualoverloads. Thedualon a raw TensorKitSectors sector moves toTensorAlgebraTensorKitSectorsExt(ITensor/TensorAlgebra.jl#215) anddualon a TensorKitElementarySpacemoves toTensorAlgebraTensorKitExt, so both are dropped here. Bumps the TensorAlgebra compat floor to 0.17.9.