Make twist! a no-op on non-graded arrays - #217
Open
mtfishman wants to merge 1 commit into
Open
Conversation
Adds a fallback twist!(a::AbstractArray, dims) = a so twist! is total over array types. A non-graded array carries no sector data, so there is no braiding and the twist is the identity. This covers the dense and Diagonal blocks that factorizations of unsymmetric arrays produce, which previously hit a MethodError because twist! was defined only for graded arrays.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
=======================================
Coverage 84.78% 84.78%
=======================================
Files 28 28
Lines 2083 2084 +1
=======================================
+ Hits 1766 1767 +1
Misses 317 317
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a fallback
twist!(a::AbstractArray, dims) = asotwist!is total over array types. A non-graded array carries no sector data, so there is no braiding and the twist is the identity. This covers the dense andDiagonalblocks that factorizations of unsymmetric arrays produce, which previously hit aMethodErrorbecausetwist!was defined only for graded arrays.