Skip to content

IRSS: Change il_resource_flavour.variant to length 638 #11718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lscharmer wants to merge 1 commit into
base: trunk
Choose a base branch
from
+12 −3
Open

IRSS: Change il_resource_flavour.variant to length 638 #11718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions components/ILIAS/ResourceStorage/classes/Setup/DB/class.ilResourceStorageDB90.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,4 +112,13 @@ public function step_4(): void
'default' => RevisionStatus::PUBLISHED->value
]);
}

public function step_5(): void

@mjansenDatabay mjansenDatabay Jul 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding a new file for ILIAS 12 update steps. Maybe you can use #11616 , even if this is not integrated in the trunk, yet.

@chfsx chfsx Jul 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjansenDatabay thanks, es exactly, the steps should follow the guideline from #11616 . @lscharmer could you update this PR accordingly?

{
$this->db->modifyTableColumn('il_resource_flavour', 'variant', [
'notnull' => false,
'length' => 638,
'type' => ilDBConstants::T_TEXT,
]);
}
}
2 changes: 1 addition & 1 deletion components/ILIAS/ResourceStorage/src/Flavour/Definition/FlavourDefinition.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public function getInternalName(): string;
* such variants must be distinguishable. For example, a variant name may contain "{height}x{width}"
* if these are configurable values.
*
* The Variant-Name MUST be less than 768 characters long!
* The Variant-Name MUST be less than 638 characters long!
*/
public function getVariantName(): ?string;

Expand Down
2 changes: 1 addition & 1 deletion components/ILIAS/ResourceStorage/src/Flavour/FlavourBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
*/
class FlavourBuilder
{
public const VARIANT_NAME_MAX_LENGTH = 768;
public const VARIANT_NAME_MAX_LENGTH = 638;
private array $current_revision_cache = [];
private array $resources_cache = [];

Expand Down
2 changes: 1 addition & 1 deletion components/ILIAS/ResourceStorage/tests/Flavours/FlavourTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public function testDefinitionVariantNameLengths(): void
$flavour_definition = $this->createMock(FlavourDefinition::class);
$flavour_definition->expects($this->exactly(2))
->method('getVariantName')
->willReturn(str_repeat('a', 768));
->willReturn(str_repeat('a', 638));

$flavour_builder->has(
new ResourceIdentification('1'),
Expand Down
Loading