UI: Use custom HTML elements for the UI Tag Input#11715
Open
lscharmer wants to merge 1 commit into
Open
Conversation
2edf85d to
e3f8c43
Compare
thibsy
reviewed
Jul 3, 2026
thibsy
left a comment
Contributor
There was a problem hiding this comment.
Hi @lscharmer,
Thx for providing this fix.
This is another good example of why the @yaiero/tagify library keeps causing friction. We repeatedly work around some issues or limitations to bend this library to all our needs, which keeps trading one problem for another and adds much unnecessary complexity. We should get rid of this library short-term.
For this PR specifically, please help me answer the following questions:
- Isn't there an existing element that supports all attributes the library needs? Maybe even an
<input type="hidden">(although this might be tricky due to name etc.)? - If I remember correctly, we originally moved to a
divbecause the custom HTML tag of the library was flagged during an A11Y inspection or some HTML-validator run (not entirely sure though). Would we not simply cause this issue again, since we embed a custom HTML tag of our own?
Thx for your insight.
Kind regards,
@thibsy (as UI coordinator)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes Mantis Bugs:
The library
@yaireo/tagifywhich is used for the UI Tag Input uses non existing HTML tags (e.g.<tags>,<tag>). We already replaced these with<div>'s instead but this results in invalid attributes used for our replacement tags (as reported in the Mantis issues above).This PR replaces the
<div>'s with custom HTML elements, so that this won't result in invalid HTML attributes anymore (https://developer.mozilla.org/en-US/docs/Web/API/Web_components/Using_custom_elements).