Skip to content

Store a copy of wazi deploy evidence file for MCP tooling - #410

Open
dennis-behm wants to merge 3 commits into
IBM:mainfrom
dennis-behm:feature/409-ability-to-store-a-copy-of-the-evidence-file-for-the-mcp-tooling
Open

Store a copy of wazi deploy evidence file for MCP tooling#410
dennis-behm wants to merge 3 commits into
IBM:mainfrom
dennis-behm:feature/409-ability-to-store-a-copy-of-the-evidence-file-for-the-mcp-tooling

Conversation

@dennis-behm

Copy link
Copy Markdown
Member

Changes:

  • wazideploy-deploy.sh (v1.30): initialize wdSharedEvidencesLocation variable,
    validate wdSharedEvidencesPath directory at startup, compute a timestamped
    target path <path>/<app>/deploy_<timestamp>.yaml, log the shared evidences
    path in the startup banner, copy the evidence file to the shared location
    after deployment, and log the wazideploy-deploy return code.
  • pipelineBackend.config: add optional wdSharedEvidencesPath setting with
    inline documentation.
  • README.md: document the wdSharedEvidencesPath behaviour in the
    wazideploy-deploy.sh introductory section.

Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>

@monvora monvora left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my embedded comment.

echo $ERRMSG
else
timestamp=$(date +"%Y-%m-%d_%H-%M-%S")
wdSharedEvidencesLocation=${wdSharedEvidencesPath}/${App}/deploy_${timestamp}.yaml

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this should be a directory?

Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>

@monvora monvora left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to store a copy of the evidence file for the MCP tooling

2 participants