Add generic per-bidder static param overrides for PBS#618
Open
Add generic per-bidder static param overrides for PBS#618
Conversation
Renames the new field to match the existing `bid_param_zone_overrides` naming convention. Updates all references: struct field, env var key, doc comments, TOML example, tests, and .env.example. Also replaces production IDs in test fixtures and examples with generic placeholder values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bid_param_overridestoPrebidIntegrationConfig— aHashMap<String, Json>that lets operators enforce static per-bidder parameters on every outgoing Prebid Server request, regardless of zone context.bid_param_zone_overrides, giving operators a reliable way to inject server-side bidder IDs that client-side Prebid config cannot override.merge_bidder_param_objecthelper.Changes
crates/trusted-server-core/src/integrations/prebid.rsbid_param_overridesfield onPrebidIntegrationConfig;merge_bidder_param_objecthelper; apply static overrides before zone overrides in OpenRTB construction; testscrates/trusted-server-core/src/settings.rsTRUSTED_SERVER__INTEGRATIONS__PREBID__BID_PARAM_OVERRIDEStrusted-server.toml.env.exampleCloses
Closes #617
Related: #339, #383, #384
Test plan
cargo test --workspacecargo clippy --workspace --all-targets --all-features -- -D warningscargo fmt --all -- --checkcd crates/js/lib && npx vitest runcd crates/js/lib && npm run formatcd docs && npm run formatChecklist
unwrap()in production code — useexpect("should ...")tracingmacros (notprintln!)