Better align highlight-bar to new YT embed seek bar - #837
Merged
Merged
Conversation
YT seek bar uses 30px padding, plus the seek ball itself is 12px wide, so 36px from left edge to 0:00, same at the end Also improve granularity of timestamp chips to 0.1% instead of 1%
FlaminSarge
force-pushed
the
highlight-bar-align
branch
from
May 20, 2026 09:16
cb1e2b7 to
3f62b3c
Compare
Contributor
Author
|
Adjusted to 0.25% granularity because 0.1% could end up really really close together in worst-case (961px window width + timestamps right next to each other, which is a pretty niche case but still). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YT seek bar uses 30px padding, plus the seek ball itself is 12px wide, so 36px from left edge to 0:00, same at the end
Also improve granularity of timestamp chips to
0.1%0.25% instead of 1%, and uses floor instead of round for consistency (going further to 0.01% didn't really improve the positioning any more).Yes, it reduces the amount of space they have available, so the padding change might be fine to skip, but the granularity should definitely be fixed, as right now it causes far too many timestamps to step on each others' toes.
Screenshots (highlight chips moved to overlay the seek bar for comparison):
Previous - yellow chip being clicked + resulting seekbar location:
Updated - center chip being clicked + resulting seekbar location:
Previous https://holodex.net/watch/DE7WL-YLk8Y:
Updated https://holodex.net/watch/DE7WL-YLk8Y: