fix(tui): archive completed background shell output#4724
Open
qinlinwang wants to merge 1 commit into
Open
Conversation
When a background shell reaches a terminal state, persist the final visible stdout/stderr tail on its originating ExecCell instead of leaving it only in live_output. This keeps completed background shell cards stable for transcript history and output summaries while preserving live updates for running jobs. Finalizing the ExecCell also freezes the displayed duration, preventing completed jobs from receiving later elapsed-time snapshots until cleanup. Add coverage for finalizing a completed background shell card.
Contributor
|
Thanks @qinlinwang for taking the time to contribute. This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered. Please read |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
originating ExecCell when the job reaches a terminal state.
Why:
Completed jobs remained in ShellManager for up to one hour. Their snapshots
compute elapsed_ms from started_at, so an ExecCell with no final output kept
accepting later snapshots and its displayed time continued to grow after the
process had already ended.
Scope:
Testing
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-featurescargo test --workspace --all-featuresChecklist