Skip to content

chore(deps): patch npm lockfiles for Dependabot alerts#4714

Open
Hmbown wants to merge 1 commit into
mainfrom
codex/v091-security-deps
Open

chore(deps): patch npm lockfiles for Dependabot alerts#4714
Hmbown wants to merge 1 commit into
mainfrom
codex/v091-security-deps

Conversation

@Hmbown

@Hmbown Hmbown commented Jul 22, 2026

Copy link
Copy Markdown
Owner

Summary

Apply npm audit fix --package-lock-only across npm workspaces to resolve the 17 open Dependabot alerts (7 high, 10 moderate) on the v0.9.1 merged tree.

Changes

  • integrations/feishu-bridge/package-lock.json: protobufjs 7.6.47.6.5
  • extensions/vscode/package-lock.json: brace-expansion 5.0.65.0.7, js-yaml 4.2.04.3.0, fast-uri 3.1.23.1.4, linkify-it 5.0.15.0.2
  • web/package-lock.json: brace-expansion/js-yaml and other transitive dev deps updated to patched versions
  • package-lock.json: refreshed transitive lockfile metadata

Remaining npm audit findings (require breaking changes or upstream patch)

  • sharp <0.35.0 (via miniflare/next/wrangler) in web/ and root: no non-breaking patch available; miniflare pins sharp 0.34.5. The website is not deployed for v0.9.1, so exposure is build-time only.
  • axios in feishu-bridge lockfile is already resolved to 1.18.1; the Dependabot alerts appear stale against the current lockfile.

Verification

  • integrations/feishu-bridge: npm ci && npm run check && npm run test — 19 passed
  • extensions/vscode: npm ci && npm run check — compiles
  • web: npm ci && npm run prebuild && npm run check:facts && npm test && npm run lint && npm run build — green
  • cargo audit on Cargo.lock — 0 vulnerabilities (one ttf-parser unmaintained informational warning already tracked in deny.toml)

Test plan

  • Dependabot alert packages patched where a safe non-breaking update exists
  • Affected workspace tests and build gates pass
  • Hosted CI green after merge

Refs #4713.

Apply `npm audit fix --package-lock-only` across npm workspaces to
resolve the 17 open Dependabot alerts (7 high, 10 moderate) on the
v0.9.1 merged tree:

- integrations/feishu-bridge: protobufjs 7.6.4 → 7.6.5
- extensions/vscode: brace-expansion 5.0.6 → 5.0.7, js-yaml 4.2.0 → 4.3.0,
  fast-uri 3.1.2 → 3.1.4, linkify-it 5.0.1 → 5.0.2
- web: brace-expansion/js-yaml and other transitive dev deps updated to
  patched versions; build, lint, tests, and `check:facts` still pass
- root package-lock: refreshed transitive lockfile metadata

Remaining npm audit findings:
- sharp <0.35.0 (via miniflare/next/wrangler) in web and root: no
  non-breaking patch available; miniflare pins sharp 0.34.5. Website is
  not deployed for v0.9.1, so exposure is build-time only.
- axios in feishu-bridge lockfile is already resolved to 1.18.1; the
  Dependabot alerts appear stale against the current lockfile.

All affected workspace checks pass:
- integrations/feishu-bridge: `npm run check && npm run test` — 19 passed
- extensions/vscode: `npm run check` — compiles
- web: `npm run prebuild && npm run check:facts && npm test && npm run lint
  && npm run build` — green

Refs #4713

Generated with [Devin](https://devin.ai)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 22, 2026 22:44
@cursor

cursor Bot commented Jul 22, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@claude

claude Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Claude finished @Hmbown's task in 1m 16s —— View job


Claude finished the review

  • Gather context (diff, changed lockfiles, CLAUDE.md/AGENTS.md guidance)
  • Understand the request (review-only, no implementation requested)
  • Review lockfile diffs for correctness
  • Check for provider/model-route safety concerns
  • Check for duplication/dead-code/reuse concerns
  • Check test coverage / verification claims
  • Check security implications of remaining unresolved findings (sharp, axios)

Summary

This is a clean, mechanical npm audit fix --package-lock-only sweep — only the 4 lockfiles changed, no package.json manifests touched, so there's no dependency-range or API-surface drift to review beyond version pins.

Verified claims in the PR description:

  • integrations/feishu-bridge/package-lock.json:117axios is indeed already 1.18.1, confirming the note that the Dependabot alert is stale against the current lockfile.
  • package-lock.json:1330 / web/package-lock.json:11475sharp is 0.34.5 (pinned by miniflare), consistent with the "no non-breaking patch available" note.
  • deny.toml:15 — the ttf-parser RUSTSEC informational suppression is present and pre-dated this PR, matching the cargo audit note.
  • All 4 lockfiles keep lockfileVersion: 3; no format drift.
  • extensions/vscode and integrations/feishu-bridge diffs are minimal, surgical version bumps (brace-expansion, js-yaml, fast-uri, linkify-it, protobufjs) exactly matching the PR body.

One thing worth calling out (not a blocker): the root package-lock.json and web/package-lock.json diffs pull in a fair amount beyond the named CVEs — e.g. wrangler 4.103.0 → 4.113.0, miniflare/workerd date-stamped releases, and a batch of @aws-sdk/@smithy transitive bumps. These are all within the ^ ranges already declared in package.json (wrangler: ^4.103.0 at root, ^4.107.0 in web/), so npm audit fix legitimately refreshed the whole transitive graph rather than cherry-picking single packages — expected behavior for this command, and all affected packages are dev-only tooling for the Cloudflare Workers build, not runtime/production code. Given web/ isn't deployed for v0.9.1 per the PR body, blast radius is effectively build-time only. Flagging only so the "596 additions" isn't mistaken for scope creep — it's npm audit fix doing its normal transitive-resolution refresh, not manual edits.

No correctness bugs, no provider/model-route logic touched (no Rust code in this diff), no dead code or missed test coverage applicable — this is dependency metadata only, and the PR's own verification steps (workspace check/test/build runs, cargo audit) are the right gate for this kind of change.

Nit: the checklist in the PR body has [ ] Hosted CI green after merge — CI (Web Frontend, CI) was still in progress at review time; worth confirming before merge but not something this review can resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants