xdg-open, so it doesn't just open in neovim or a browser?

[FranckKernel]

Support so that you go

gk or whatever on

"$HOME/Documents/Life and Shit/Some video.mp4"
^ cursor here.

gk and it opens it with xdg-open, or maybe you could make that a user config thing.

[FranckKernel]

Also, what about if it's under the current cursor?
it's currently not supported, or am i missing an option?

[HawkinsT]

Sorry, what do you mean by if it's under the current cursor? The plugin has look ahead so you can open files on subsequent lines, e.g. with 2gf, or do you mean something else?

[FranckKernel]

"$HOME/Documents/Life and Shit/Some video.mp4"

====== somefile.md ======

1: "$HOME/□ocuments/Life and Shit/Secret Sauce.txt"
2: "$HOME/□ocuments/Life and Shit/Some video.mp4"

Cursor on the square.

Line one: A video file.
Line 2: A text file.

On line 1 (one), you have your cursor on the square, you press gX, it xdg opens that video file. So, a new window pop up with the users default video player.

On line 2 (two), you press gf, it opens this file in a neovim buffer

First case (gf) does:
:e $HOME/some file with space.txt

second case does:
!xdg-open $HOME/some video with space.mp4

press gX it opens the video in a new window.

press "Up Arrow" gf, it opens the file in a new buffer.

=====
I downloaded this because it's supposed to have (it does) better support for spaces and $HOME then the default neovim stuff.
The default gf fails with spaces.

but it's wack if i need to have my cursor before it.

it works for gf, but fails for gx.

=====

press gx, it fails, i need to place my cursor before the url link

[FranckKernel]

so

gf, opens file under cursor in neovim buffer.
gx, opens url under cursor in default browser.
gX, opens file path under cursor in default application. (xdg-open file_path)

[FranckKernel]

something like this for gX.

local function get_file_under_cursor()
	local line = vim.api.nvim_get_current_line()
	local col = vim.fn.col(".") -- 1-indexed
	-- print("Cursor at column:", col)
	-- print("Line:", line)

	local path = nil

	-- search for quotes
	for s, quote_char, content, close_quote, e in line:gmatch("()([\"'])(.-)([\"'])()") do
		-- print("Found quote:", quote_char, "start:", s, "end:", e, "content:", content)
		if col > s and col < e then
			path = content
			-- print("Cursor inside quotes! Path:", path)
			break
		end
	end

	if not path then
		path = vim.fn.expand("<cfile>")
		-- print("Cursor not inside quotes. Using <cfile>:", path)
	end

	-- expand ~ and $HOME
	path = path:gsub("^%$HOME", os.getenv("HOME")):gsub("^~", os.getenv("HOME"))
	-- print("Expanded path:", path)

	return path
end

local function open_file_under_cursor()
	local path = get_file_under_cursor()
	if vim.fn.filereadable(path) == 1 or vim.fn.isdirectory(path) == 1 then
		-- print("Opening:", path)
		vim.fn.jobstart({ "xdg-open", path }, { detach = true })
	else
		vim.notify("Path does not exist: " .. path, vim.log.levels.ERROR)
	end
end

vim.keymap.set("n", "gk", open_file_under_cursor, { desc = "Open file under cursor (spaces/quotes supported)" })
vim.keymap.set("n", "gX", open_file_under_cursor, { desc = "Open file under cursor (spaces/quotes supported)" })
``

=====
could replaced the hard coded xdg-open by user.config.opener or something. 

[HawkinsT]

Okay, so there are two separate issues (let me know if there's anything I've missed). I see gx has a bug where it opens ahead of the cursor, not on the URL under the cursor. I'll fix that.

Separately, you want an 'open externally' command. I can add this functionality, but for now if you add the following to your config this should do what you want (with the caveat that it relies on a hardcoded wait):

local pf = require("pathfinder")
local cfg = require("pathfinder.config")

local function open_externally(trigger_fn)
	local prev_mode = cfg.config.open_mode
	local prev_reuse = cfg.config.reuse_existing_window
	local restored, opened = false, false

	local function restore()
		if restored then
			return
		end
		restored = true
		cfg.config.open_mode = prev_mode
		cfg.config.reuse_existing_window = prev_reuse
	end

	cfg.config.reuse_existing_window = false
	cfg.config.open_mode = function(escaped_path, _, _)
		if opened then
			return
		end
		opened = true
		local path = vim.fn.expand(escaped_path)
		restore()
		if path ~= "" then
			vim.ui.open(path)
		end
	end

	local ok, err = pcall(trigger_fn)

	if ok and not opened then
		vim.wait(800, function()
			return opened
		end, 10)
	end

	restore()
	if not ok then
		error(err)
	end
end

vim.keymap.set("n", "gX", function()
	open_externally(function()
		pf.gf()
	end)
end, { desc = "Pathfinder: open file externally", silent = true })

vim.keymap.set("n", "<leader>gX", function()
	open_externally(function()
		pf.select_file()
	end)
end, { desc = "Pathfinder: select file and open externally", silent = true })

[FranckKernel]

Yep. It was those two issues.

1. gx doesnt work for under cursor. Only forward look.
2. Some external opening would be nice. Idk if vim.ui.open is a multiplatform wrapper over xdg-open.

[HawkinsT]

Yeah, vim.ui.open should handle all OS's.

[HawkinsT]

fea57a2 should fix the off-by-one error in gx. While this plugin's xdg-open behaviour for gx deviates from default Neovim behaviour (which I hadn't considered), I'm treating this as a feature request and will address it in due course.