Repository navigation
Fix reverse-mode gradients for Dirichlet batches - #829
Open
AHMETHAKANBEZIR1 wants to merge 1 commit into
Open
AHMETHAKANBEZIR1 wants to merge 1 commit into
AHMETHAKANBEZIR1 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SciPy evaluates Dirichlet densities for a matrix whose columns are samples, but the reverse-mode rules broadcast the concentration vector against the sample axis and do not reduce concentration gradients across samples. For example, differentiating a summed
logpdfwith three components and two samples raises a broadcasting error even though density evaluation succeeds.Compute the local derivatives in sample-major order, restore the original coordinate layout, and use the existing
unbroadcast_fhelper to accumulate gradients for shared concentrations. This covers batches with all simplex components supplied; support for SciPy's abbreviated last-component input is unchanged.Validation:
python -m pytest -n 2— 651 passed, 14 warnings on Python 3.12.14, NumPy 2.5.4, SciPy 1.18.1.git diff --checkpass. Forward-mode support is unchanged.AI disclosure: OpenAI Codex autonomously prepared the code, tests, and this description. Validation and an additional AI review were performed; there has been no independent human review.