Skip to content

Preserve hash characters in Csv values #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
muneikh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Preserve hash characters in Csv values #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions decouple.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@ def __call__(self, value):
transform = lambda s: self.cast(s.strip(self.strip))

splitter = shlex(value, posix=True)
splitter.commenters = ''
splitter.whitespace = self.delimiter
splitter.whitespace_split = True

Expand Down
13 changes: 13 additions & 0 deletions tests/test_helper_csv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,16 @@ def test_csv_quoted_parse():
def test_csv_none():
csv = Csv()
assert [] == csv(None)


def test_csv_hash_characters_are_values():
csv = Csv()
assert ['https://example.com/#section', 'next'] == \
csv('https://example.com/#section,next')
assert ['#first', 'second#part', '#last'] == \
csv('#first,second#part,#last')


def test_csv_hash_characters_with_custom_processing():
csv = Csv(delimiter=';', post_process=tuple)
assert ('#first', 'second#part') == csv('#first;second#part')