Skip to content

fix: restrict registration gift to parent wallets - #548

Draft
samwel141 wants to merge 1 commit into
Greenstand:feat/gift-tokenfrom
samwel141:fix-parent-wallet-registration-gift
Draft

samwel141 wants to merge 1 commit into
Greenstand:feat/gift-tokenfrom
samwel141:fix-parent-wallet-registration-gift

Conversation

@samwel141

Copy link
Copy Markdown
Collaborator

Description

Restricts the first-wallet count used by the registration gift flow to parent wallet creation. Managed wallet creation no longer runs the count or qualifies for the registration gift.

Follow-up to the review on #543.

Issue(s) addressed

What kind of change(s) does this PR introduce?

  • Enhancement
  • Bug fix
  • Refactor

Please check if the PR fulfils these requirements

  • The commit message follows our guidelines
  • Existing unit tests pass
  • Docs have been added / updated (not applicable)

Issue

What is the current behavior?
The first-wallet count runs for both parent and managed wallet creation, allowing managed wallets to enter the registration gift decision.

What is the new behavior?
The first-wallet count only runs when creating a parent wallet (!wallet_id).

Breaking change

Does this PR introduce a breaking change?
No.

Other useful information

npm run test-unit-ci: 234 passing.

@samwel141 samwel141 self-assigned this Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant