fix(docker): Restore Vite+ release image builds - #188
Merged
Conversation
Use the installer executable path and verify vp before installing Console dependencies. Build all release runtime variants and check their packaged binaries in the Quality workflow. Refs #187
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release image builds failed at
vp install --frozen-lockfilebecause the Dockerfile added/root/.vite-plus/binto PATH while the installer placed Vite+ in/root/.local/share/vite-plus/bin. Use the actual installation path and verifyvpimmediately after installation.The Quality workflow now builds the Debian, Slim, and Alpine release targets through the same Docker Bake definition used for publishing, then runs both packaged binaries with
--version. Validation images remain local to the CI runner. The self-hosting guide documents this coverage.Validation
grass-control-api --versionandgrass-node --versionsuccessfully in each image with networking disabled.just qualitypassed: 483 Control API tests, 117 Node tests, and 225 Console tests, plus formatting, lint, checks, builds, and license validation. Infrastructure-dependent ignored tests were not rerun for this Dockerfile/workflow change.actionlintpassed for the updated Quality workflow.git diff --checkpassed.832d6794. On Linux AMD64, all three release variants built successfully and both packaged binaries started in each image.Tracking
Closes #187
Parent: #28
Repeat the closing reference when promoting
developto the defaultmainbranch.