feat: add support for Gremlin negated text predicates - #340
Open
jakeboone02 wants to merge 5 commits into
Open
Conversation
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Contributor
Author
|
I had some trouble running tests locally, and I'm not sure why the Benchmark (PR) CI job failed, but otherwise I think this is ready to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for Gremlin negated text predicates
notContaining,notStartingWith, andnotEndingWith.How was it tested?
Local
cargo test --all-features --workspace.Community PR checklist
grafeo-core/grafeo-engineinternals, or new feature flags were either (a) requested in the linked issue or (b) discussed and approved in a GitHub Discussion before this PR was opened..github/workflows/), the rootCargo.toml,codecov.yml, andscripts/are not modified unless the change is the explicit purpose of this PR.Summary by cubic
Adds support for Gremlin negated text predicates:
notContaining,notStartingWith, andnotEndingWith. Enables negative substring, prefix, and suffix filters inhas(), and removes redundant Gremlin tests.notContaining,notStartingWith,notEndingWith.Contains/StartsWith/EndsWith.has('prop', not...())cases.Written for commit 1d458c7. Summary will update on new commits.