Repository navigation
fix: embed contract metadata and report compile-time version - #816
Open
EurekaZainMalik wants to merge 1 commit into
Open
EurekaZainMalik wants to merge 1 commit into
EurekaZainMalik wants to merge 1 commit into
Conversation
|
@EurekaZainMalik Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR embeds contract metadata (
contractmeta!) into the milestone-escrow WASM so explorers andstellar contract info metacan surface the contract name, version and source repo, and changesversion()to return a compile-timeCONTRACT_VERSIONconstant instead of an incrementing upgrade counter.DataKey::Versionis retained as the storage schema version for migrations.Related Issue
Changes
📦 Contract Metadata
[MODIFY]
contracts/milestone-escrow/src/lib.rscontractmeta!(key = "name", val = "milesto-milestone-escrow").contractmeta!(key = "version", val = env!("CARGO_PKG_VERSION")).contractmeta!(key = "source_repo", val = "...")pointing at the source repository.CONTRACT_VERSIONconstant derived fromCARGO_PKG_VERSION.version()to returnCONTRACT_VERSIONinstead of readingDataKey::Version.DataKey::Versionas the storage schema version used by migrations;initialize/upgradeno longer drive the reported version.[MODIFY]
contracts/milestone-escrow/Cargo.tomlversionis the single source of truth consumed byenv!("CARGO_PKG_VERSION").[ADD]
contracts/milestone-escrow/src/version_tests.rsversion()matches theCargo.tomlpackage version.version()is stable acrossupgradecalls (no longer increments).Verification Results
stellar contract info meta --wasm ...shows name, version and repocontractmeta!entries added for name, version and source repoversion()matchesCargo.tomlin testsversion_tests.rsCloses #735