Repository navigation
Land #794: entry-point cost budgets, admin multisig decision, mainnet checklist - #815
Open
godamongstmen897 wants to merge 4 commits into
Open
godamongstmen897 wants to merge 4 commits into
godamongstmen897 wants to merge 4 commits into
Conversation
…nd track regressions
…checklist cost_tests did not compile: the crate is no_std (println needs extern crate std), InvocationResources::instructions is i64 and there is no memory_read_bytes (mem_bytes is the memory figure). Disputes now require a delivered milestone (#784), so the dispute flows mark delivery first. #764 asks the test to fail on an extra storage write in fund; it only asserted instructions > 0. Add per-entry-point budgets from the current baselines (exact write entries, ~10% headroom on instructions and write bytes). Checked: an extra persistent write in fund fails with 'fund: 5 ledger writes exceeds the budget of 4'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017wV2kkBR3SpUPRe6CVe4te
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges contributor PR #794 (mathstickz) onto main with these fixes:
cost_tests:no_std, soprintln!needsextern crate std.InvocationResources::instructionsisi64, and there is nomemory_read_bytes(mem_bytesis the memory figure).instructions > 0, so it couldn't catch a regression. It now enforces per-entry-point budgets from the current baselines: exact for ledger write entries, about 10% headroom for instructions and write bytes. I checked it by adding an extra persistent write tofund, which fails withfund: 5 ledger writes exceeds the budget of 4.Current numbers (gzip-free host metering):
#762 is covered by
ADMIN_MULTISIG_DECISION.md, and #763 byMAINNET.md, linked from the README.Local run: all checks pass with 1234 tests.
Closes #762, closes #763, closes #764
Generated by Claude Code