#940 Show Selenium tests in noVNC again - #1064
Merged
Merged
Conversation
Chrome ran with --headless everywhere, so the Selenium container's virtual display stayed empty and noVNC had nothing to show. Keep headless on CI only. ddev does not pass CI into the containers, so set it in the global config that CI copies. This also makes the existing screenshot guard work. Enlarge the virtual display to fit the window size the tests ask for, and drop the VNC password from the README, since the container runs with VNC_NO_PASSWORD. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Collaborator
Author
|
0.5h |
AronNovak
reviewed
Aug 19, 2026
AronNovak
approved these changes
Aug 19, 2026
Co-authored-by: Aron Novak <AronNovak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #940
Root cause
ServerGeneralSelenium2TestBase::getDriverInstance()builds its own Chrome capabilities and hardcodes--headless, so it ignoresDTT_MINK_DRIVER_ARGS. Headless Chrome never draws on the Selenium container's virtual display, so noVNC showed an empty desktop.Regression from #912, which reinstalled the addon fresh and restored the upstream
--headlessdefaults, undoing c69a58d.Changes
ci-scripts/global_config.yamlsetsCI=trueinweb_environment. The runner setsCI, but ddev does not pass it into the containers, sogetenv('CI')was never true there. This also repairs the screenshot guard intakeScreenshot()..ddev/docker-compose.selenium-chrome_screen.yamlenlarges the virtual display to 1920x1920, so the 1900x1900 window the tests ask for is not cut off. Separate file so the#ddev-generatedaddon files stay upgradable.secretpassword. The container runs withVNC_NO_PASSWORD=1.🤖 Generated with Claude Code