chore!: replace is-terminal with std::io::IsTerminal - #75
Merged
Sebastian Thiel (Byron) merged 1 commit intoOct 1, 2026
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Removing the implicit public Cargo feature creates a downstream compatibility break.
Review effort: Balanced
Findings: 1
What changed in this PR
Replaces the is-terminal dependency with Rust’s standard IsTerminal API.
Changes:
- Updates terminal detection calls.
- Removes the external dependency and lockfile entries.
- Keeps the autoconfiguration feature dependency-free.
| File | Description |
|---|---|
src/render/line/engine.rs |
Uses standard terminal detection. |
examples/shared/mod.rs |
Updates example terminal detection. |
Cargo.toml |
Removes the dependency. |
Cargo.lock |
Removes resolved dependency entries. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Falk Woldmann Lu (FalkWoldmann)
force-pushed
the
replace-is-terminal
branch
from
October 1, 2026 07:41
e2ea870 to
5d0f85c
Compare
Member
|
Actually, let's undo this and keep Will merge when done. Would do it myself but don't want to destroy your signature. |
Sebastian Thiel (Byron)
force-pushed
the
replace-is-terminal
branch
from
October 1, 2026 09:11
5d0f85c to
6e49a33
Compare
Member
|
Thanks a lot! I had to go ahead and make the modification myself, allowing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.