Skip to content

chore!: replace is-terminal with std::io::IsTerminal - #75

Merged
Sebastian Thiel (Byron) merged 1 commit into
GitoxideLabs:mainfrom
FalkWoldmann:replace-is-terminal
Oct 1, 2026
Merged

Sebastian Thiel (Byron) merged 1 commit into
GitoxideLabs:mainfrom
FalkWoldmann:replace-is-terminal

Conversation

@FalkWoldmann

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Removing the implicit public Cargo feature creates a downstream compatibility break.

Review effort: Balanced
Findings: 1 High severity

Open (1)
What changed in this PR

Replaces the is-terminal dependency with Rust’s standard IsTerminal API.

Changes:

  • Updates terminal detection calls.
  • Removes the external dependency and lockfile entries.
  • Keeps the autoconfiguration feature dependency-free.
File Description
src/​render/​line/​engine.rs Uses standard terminal detection.
examples/​shared/​mod.rs Updates example terminal detection.
Cargo.toml Removes the dependency.
Cargo.lock Removes resolved dependency entries.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Cargo.toml
@FalkWoldmann Falk Woldmann Lu (FalkWoldmann) changed the title chore: replace is-terminal with std::io::IsTerminal chore!: replace is-terminal with std::io::IsTerminal Oct 1, 2026
@Byron

Byron commented Oct 1, 2026

Copy link
Copy Markdown
Member

Actually, let's undo this and keep chore: - I realise now that this was just an auto-feature for the optional is-terminal dependency. Falk Woldmann Lu (@FalkWoldmann) .

Will merge when done. Would do it myself but don't want to destroy your signature.

@Byron

Byron commented Oct 1, 2026

Copy link
Copy Markdown
Member

Thanks a lot!

I had to go ahead and make the modification myself, allowing gix (CLI) to compile without this dependency.

@Byron
Sebastian Thiel (Byron) merged commit f54a5b5 into GitoxideLabs:main Oct 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants