Repository navigation
Replace the archived audit action with cargo-deny advisories - #157
Merged
Eliah Kagan (EliahKagan) merged 2 commits intoOct 29, 2026
Merged
Eliah Kagan (EliahKagan) merged 2 commits into
Eliah Kagan (EliahKagan) merged 2 commits into
Conversation
Run advisories in a separate job using the existing pinned cargo-deny action. Scan the whole workspace with all features and --locked, and report unsound and unmaintained dependencies throughout the graph. Advisory failures now fail the Security audit workflow as well as its job check. Remove cargo-audit installation, the cargo generate-lockfile wrapper, and unnecessary checks/issues write permissions. Simplify the existing bans/licenses/sources job and use the same dependency scope there. Trigger the workflow on PR changes to deny.toml as well. Removing actions-rs/audit-check resolves zizmor's archived-uses finding: https://github.com/GitoxideLabs/cargo-smart-release/security/code-scanning/149 Validated with actionlint, all four cargo-deny checks, a synthetic transitive tokio unsound-advisory fixture, and authenticated zizmor before/after scans (archived-uses before; no findings after). Co-authored-by: Codex <codex@openai.com>
Remove the pull-request path filter, matching gitoxide's CI coverage. New advisories can affect existing dependencies even when a PR changes no manifests or lockfiles, so every PR should run the checks. Co-authored-by: Codex <codex@openai.com>
EliahKagan
commented
Oct 29, 2026
EliahKagan
left a comment
Member
Author
There was a problem hiding this comment.
I've carefully read the code changes and commit messages, and the scan works. I'm fixing things up in the PR description (or having Codex do so) and I'll reread everything and merge once other CI passes.
Eliah Kagan (EliahKagan)
marked this pull request as ready for review
October 29, 2026 19:44
Eliah Kagan (EliahKagan)
deleted the
codex/run-ci/cargo-deny-advisories
branch
October 29, 2026 19:45
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
AI disclosure: This PR description was written by GPT-6.1 Sol in Codex, at Eliah Kagan's direction. The LLM also prepared the changes and commit messages and performed the reported validation and reviews.
The advisory audit now uses the existing pinned
EmbarkStudios/cargo-deny-actionin a separate job, replacing the archivedactions-rs/audit-checkaction. Unsound and unmaintained advisories are checked throughout the dependency graph, including transitive dependencies. Advisory failures fail the Security audit workflow, and it runs on every PR regardless of changed paths.Both cargo-deny jobs use
--workspace --all-features --locked, preserving committed dependency versions and covering the whole workspace. This removes cargo-audit installation, the Cargo wrapper that suppressed lockfile regeneration, and unnecessary checks/issues write permissions. The bans/licenses/sources job is also simplified by removing its single-entry matrix.Removing the archived action resolves the finding behind zizmor code-scanning alert #149. This follows the replacement anticipated in #48 and #99.
Validation:
git diff --checkpasses for the complete branch diff.--workspace --all-features --locked --offline. The temporary configuration matches this PR'sdeny.tomlexcept for pointingdb-pathat a copied advisory cache. TheBSL-1.0license-not-encountered warning occurs with both the baseline and updated configurations.unsound = "workspace"and fails withunsound = "all", reporting RUSTSEC-2026-0386. This compares cargo-deny scopes; it is not a test of the former cargo-audit action.archived-useson the baseline audit workflow and no findings on the updated audit workflow.19a4824: Security audit, including bothcargo_deny_advisoriesandcargo_deny; CI, including Linux, macOS, and Windows tests; CodeQL; and zizmor. These are successfulpull_requestruns in the upstream repository, including execution of the pinned Docker action.The PR remains a draft. The advisory job has now passed on CI for this pull request.