Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1174 +/- ##
==========================================
+ Coverage 91.97% 92.21% +0.24%
==========================================
Files 144 160 +16
Lines 6277 7686 +1409
==========================================
+ Hits 5773 7088 +1315
- Misses 504 598 +94
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
agateau-gg
force-pushed
the
agateau/msi
branch
from
40afdb8 to
7dd9978
Compare
agateau-gg
force-pushed
the
agateau/msi
branch
from
7dd9978 to
5e3229d
Compare
WiX v4.0.4 does not support the <Files> element used in ggshield.wxs, causing the MSI build to fail with WIX0005. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The <Files> element must be a direct child of <Directory>, not <Component>. It auto-generates its own components. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Files-generated components must belong to a Feature. Wrap the Files element in a ComponentGroup and reference it via ComponentGroupRef. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
What has been done
Validation
PR check list
skip-changeloglabel has been added to the PR.