You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
chore: added ring state debug runtime toggle + adjusted layout - #2598
No actionable comments were generated in the recent review.
Walkthrough
The dogfood app adds an avatar-accessible settings sheet for theme mode and ring-state debug visibility. The ring-state setting is persisted and controls whether the debug pane appears. The pane’s position and text colors are also updated.
The app hosts a bottom sheet that opens from the signed-in user’s avatar. It provides theme-mode and ring-state debug switches. The ring-state setting is persisted, and the theme option is removed from More Actions.
Ring-state debug pane control and layout sample-apps/react-native/dogfood/src/navigators/Call.tsx, sample-apps/react-native/dogfood/src/components/Ringing/RingStateDebugPane.tsx
The navigator renders the debug pane only when its setting is enabled and development mode is active. The pane’s top offset and text colors change.
sequenceDiagram
actor User
participant NavigationHeader
participant AppSettingsSheet
participant themeMode
User->>NavigationHeader: Press avatar
NavigationHeader->>AppSettingsSheet: Set visible
User->>AppSettingsSheet: Change dark-mode switch
AppSettingsSheet->>themeMode: Set to dark or light
Loading
Suggested reviewers:kristian-mkd
Merge Risk: Minimal · up to 11b87
Settings remain accessible before and after calls. No merge-blocking issue was established.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title describes the ring state debug toggle and layout changes.
Description check
The description covers the changes and includes the required headings and ticket. It does not include a docs link.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 7 files.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
Built package output. Sizes in KB; delta vs main@595b708.
No significant package size increase vs main.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Overview
This PR contains:
📝 Implementation notes
🎫 Ticket: https://linear.app/stream/issue/RN-517/dogfood-debug-ux-improvements
Summary by CodeRabbit