Skip to content

chore: added ring state debug runtime toggle + adjusted layout - #2598

Open
greenfrvr wants to merge 1 commit into
mainfrom
ring-state-ux
Open

greenfrvr wants to merge 1 commit into
mainfrom
ring-state-ux

Conversation

@greenfrvr

@greenfrvr greenfrvr commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

💡 Overview

This PR contains:

  1. Global app settings modal shown by pressing an avatar on navigation header.
  2. New runtime toggle for ring state debug UI which is stored between sessions (default value is "enabled").
  3. Adjusted ring state debug layout. Now it doesn't overlap call controls buttons.
  4. Removed theme toggle from call actions to global app settings modal.

📝 Implementation notes

App settingsRing state pane
Screenshot 2026-11-06 at 15 49 49 Screenshot 2026-11-06 at 15 43 30

🎫 Ticket: https://linear.app/stream/issue/RN-517/dogfood-debug-ux-improvements

Summary by CodeRabbit

  • New Features
    • Open app settings from the signed-in user’s avatar, with controls for dark mode and the ring-state debug panel.
    • The ring-state panel setting is available in development builds or when developer mode is enabled, and its selection is saved.
  • Improvements
    • Dark-mode control is no longer available in the call’s More Actions menu.
    • Adjusted the ring-state panel’s placement and text color for improved visibility.

@greenfrvr greenfrvr self-assigned this Nov 6, 2026
@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The dogfood app adds an avatar-accessible settings sheet for theme mode and ring-state debug visibility. The ring-state setting is persisted and controls whether the debug pane appears. The pane’s position and text colors are also updated.

Changes: Dogfood settings and ring-state debug

Layer / File(s) Summary
Settings sheet and app wiring
sample-apps/react-native/dogfood/App.tsx, sample-apps/react-native/dogfood/src/components/AppSettingsSheet.tsx, sample-apps/react-native/dogfood/src/components/NavigationHeader.tsx, sample-apps/react-native/dogfood/src/constants/TestIds.ts, sample-apps/react-native/dogfood/src/contexts/AppContext.tsx, sample-apps/react-native/dogfood/src/components/CallControls/MoreActionsButton/index.tsx
The app hosts a bottom sheet that opens from the signed-in user’s avatar. It provides theme-mode and ring-state debug switches. The ring-state setting is persisted, and the theme option is removed from More Actions.
Ring-state debug pane control and layout
sample-apps/react-native/dogfood/src/navigators/Call.tsx, sample-apps/react-native/dogfood/src/components/Ringing/RingStateDebugPane.tsx
The navigator renders the debug pane only when its setting is enabled and development mode is active. The pane’s top offset and text colors change.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  actor User
  participant NavigationHeader
  participant AppSettingsSheet
  participant themeMode
  User->>NavigationHeader: Press avatar
  NavigationHeader->>AppSettingsSheet: Set visible
  User->>AppSettingsSheet: Change dark-mode switch
  AppSettingsSheet->>themeMode: Set to dark or light
Loading

Suggested reviewers: kristian-mkd

Merge Risk: Minimal · up to 11b87

Settings remain accessible before and after calls. No merge-blocking issue was established.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title describes the ring state debug toggle and layout changes.
Description check Passed The description covers the changes and includes the required headings and ticket. It does not include a docs link.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 7 files.

Finishing Touches

Generate docstrings

  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5aed99a6-d5c0-49dc-a967-95573a182ab6
Commits

Reviewing files that changed from the base of the PR and between 595b708 and 11b8785.

Files selected for processing: 8

  • sample-apps/react-native/dogfood/App.tsx
  • sample-apps/react-native/dogfood/src/components/AppSettingsSheet.tsx
  • sample-apps/react-native/dogfood/src/components/CallControls/MoreActionsButton/index.tsx
  • sample-apps/react-native/dogfood/src/components/NavigationHeader.tsx
  • sample-apps/react-native/dogfood/src/components/Ringing/RingStateDebugPane.tsx
  • sample-apps/react-native/dogfood/src/constants/TestIds.ts
  • sample-apps/react-native/dogfood/src/contexts/AppContext.tsx
  • sample-apps/react-native/dogfood/src/navigators/Call.tsx
Files with no reviewable changes: 1

  • sample-apps/react-native/dogfood/src/components/CallControls/MoreActionsButton/index.tsx

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

Bundle size

Built package output. Sizes in KB; delta vs main@595b708.

No significant package size increase vs main.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant