Add a maximum topography for external usage - #945
Open
Minerallo wants to merge 3 commits into
Open
Conversation
Minerallo
changed the title
6 tasks
Coverage Report for CI Build 30487714247Coverage increased (+0.008%) to 98.308%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
|
MFraters
reviewed
Jul 26, 2026
MFraters
left a comment
MFraters
left a comment
Member
There was a problem hiding this comment.
Looks generally good, but I have a few comments. I would like t ask you to add tests for every plugin and also add a test to show that you actually picked the correct max topography.
Would you also be willing to add a minimum topography function, while you are add it?
| * feature. Features without topography return zero. | ||
| */ | ||
| virtual | ||
| double maximum_topography() const; |
Member
There was a problem hiding this comment.
I think every plugin should implement this, because there is no sensible default implementation. So could you make it const = 0;?
Contributor
Author
There was a problem hiding this comment.
Done. now its double maximum_topography() const = 0;
|
|
||
| - Added Perlin noise models for composition and temperature across features, and gwb-dat coverage tests for Cartesian Perlin noise inputs. \[Tilman May; 2026-03-29; [#906](https://github.com/GeodynamicWorldBuilder/WorldBuilder/pull/906)\] | ||
|
|
||
| - Added a `maximum_topography()` API that returns a guaranteed upper bound for all configured topography models. \[Michael Pons; 2026-07-26\] |
Member
There was a problem hiding this comment.
Can you add this pull request as a reference at the end?
Comment on lines
+66
to
+71
| double | ||
| Interface::maximum_topography() const | ||
| { | ||
| return 0.0; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
I don't think the interface should define a default version. I think every plugin should define a correct value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone,
this PR adds
World::maximum_topography(). It returns an upper bound for thetopography configured in World Builder. This allows applications such as
ASPECT to determine the required geometry size before creating the mesh.
I added tests for a model with uniform topography and for a model without
topography. The complete unit test suite passes.
Cheers,
Michael