Skip to content

Optimize allocations (get them out of loops) with the help of heaptrack. - #944

Open
MFraters wants to merge 1 commit into
mainfrom
pr-b86019a940abcdfb2421e083556e5e2030421744
Open

Optimize allocations (get them out of loops) with the help of heaptrack.#944
MFraters wants to merge 1 commit into
mainfrom
pr-b86019a940abcdfb2421e083556e5e2030421744

Conversation

@MFraters

Copy link
Copy Markdown
Member

splitting up #943. This pull request modifies the properties function to allow adding an output vector. Still requires some cleaning up.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 30041099056

Coverage increased (+0.01%) to 98.312%

Details

  • Coverage increased (+0.01%) from the base build.
  • Patch coverage: 1 uncovered change across 1 file (59 of 60 lines covered, 98.33%).
  • 2 coverage regressions across 1 file.

Uncovered Changes

File Changed Covered %
source/world_builder/world.cc 32 31 96.88%
Total (2 files) 60 59 98.33%

Coverage Regressions

2 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
source/world_builder/world.cc 2 93.17%

Coverage Stats

Coverage Status
Relevant Lines: 11967
Covered Lines: 11765
Line Coverage: 98.31%
Coverage Strength: 818304.28 hits per line

💛 - Coveralls

@github-actions

Copy link
Copy Markdown
Benchmark Main Feature Difference (99.9% CI)
Slab interpolation simple none 1.176 ± 0.010 (s=393) 1.128 ± 0.013 (s=390) -4.3% .. -3.8%
Slab interpolation curved simple none 1.312 ± 0.008 (s=372) 1.255 ± 0.011 (s=331) -4.6% .. -4.2%
Spherical slab interpolation simple none 1.202 ± 0.011 (s=380) 1.160 ± 0.012 (s=384) -3.8% .. -3.3%
Slab interpolation simple curved CMS 1.342 ± 0.010 (s=340) 1.289 ± 0.008 (s=347) -4.2% .. -3.8%
Spherical slab interpolation simple CMS 1.555 ± 0.010 (s=284) 1.510 ± 0.011 (s=306) -3.1% .. -2.8%
Spherical fault interpolation simple none 1.292 ± 0.009 (s=359) 1.243 ± 0.008 (s=353) -3.9% .. -3.6%
Cartesian min max surface 3.094 ± 0.023 (s=156) 2.994 ± 0.015 (s=142) -3.5% .. -3.0%
Spherical min max surface 8.610 ± 0.132 (s=52) 8.332 ± 0.084 (s=57) -4.1% .. -2.4%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants