Conversation
…er remesh After nearest-neighbor interpolation, elements that lie fully or partially outside the old mesh (gap elements created by remeshing_option=11 restore_bottom, or any remesh that expands the domain) incorrectly inherit non-zero plastic strain from the nearest old boundary element via the kNN first-pass copy. Apply the existing boundary_field() helper to plstrain, delta_plstrain, and strain immediately after inject_field(). boundary_field() blends each field toward 0 proportionally to empty_vec (fraction of ACM sample points outside the old mesh), so purely gap elements are fully zeroed and straddling elements are partially corrected. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…elds examples/core-complex-mmg.cfg used the old parameter name, which input.cxx never registered (the current option is sim.is_outputting_averaged_fields, per examples/defaults.cfg). Checked all other .cfg files under examples/, benchmarks/, and gospl_driver/examples/ for the same stale name; this was the only one. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rqf5nW3ahreo3Skp1Lpss6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remeshing_option=11restore_bottom, or any remesh that expands the domain). These elements were previously inheriting spurious non-zero plastic strain from the nearest old boundary element via the kNN first-pass copy ininject_field(). Applies the existing (previously unused)boundary_field()helper, which blends each field toward 0 proportionally toempty_vec— fully zeroing purely-gap elements and partially correcting straddling elements.examples/core-complex-mmg.cfg:output_averaged_fieldswas never registered byinput.cxx(the actual option issim.is_outputting_averaged_fields, perexamples/defaults.cfg), so it was silently ignored. Checked all other.cfgfiles underexamples/,benchmarks/, andgospl_driver/examples/for the same stale name — this was the only occurrence.Test plan
restore_bottomremesh case and confirm gap elements no longer carry nonzero plastic strain.core-complex-mmg.cfgnow parsesis_outputting_averaged_fieldscorrectly.🤖 Generated with Claude Code
https://claude.ai/code/session_01Rqf5nW3ahreo3Skp1Lpss6