Repository navigation
fix(accounts): buffer borrow and withdraw market capacity - #562
Merged
Merged
Conversation
- Leave two basis points of available borrowing capacity for execution delays - Verify Max remains valid after market capacity decreases by one basis point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Borrow and withdraw Max can revert with
BorrowingMoreThanU2ForbiddenExceptionwhen borrowing capacity shrinks between calculation and execution. On the reported account, the unbuffered Max passed immediately but reverted after 15 seconds and one new block.Reserve two basis points (0.02%) of market borrowing capacity before comparing it with collateral and per-account debt limits. Max remains unchanged when those other limits are lower than the buffered capacity.
Validation:
eth_callafter 15 seconds and two new blocks. No transaction was sent.