Repository navigation
chore: support Ember 7.4 (upgrade ember-cli-htmlbars & addon deps) - #215
Open
dmcnamara-eng wants to merge 1 commit into
Open
dmcnamara-eng wants to merge 1 commit into
dmcnamara-eng wants to merge 1 commit into
Conversation
ember-source 7 no longer ships dist/ember-template-compiler.js, so every
v1 addon in our dependency tree that relies on ember-cli-htmlbars <= 6
fails to build.
- ember-cli-htmlbars ^6 -> ^7.0.1
- ember-cli-babel ^7 -> ^8.3.2 (+ @babel/core)
- ember-element-helper ^0.6 -> ^0.8.8 (v2)
- ember-truth-helpers ^3 -> ^5.0.0 (v2)
- ember-set-helper ^2 -> ^3.1.0 (v2)
- ember-concurrency ^2 -> ^5.3.0 (v2); decorator tasks rewritten to
task({ ... }, async () => {}) with the async-arrow transform registered
in index.js
- tracked-maps-and-sets -> tracked-built-ins ^4.1.2
- ember-modifier ^4.3.0, ember-auto-import ^2.10.0,
@embroider/macros ^1.19.0 (needed by tracked-built-ins 4)
- TypeScript 5 + @types/ember__owner so ts:precompile can read
ember-modifier 4.2+ declarations
BREAKING: requires ember-source >= 4.8 and Node >= 20. Drops the
ember-lts-4.4 scenario; test-app now runs on Ember 4.8.
Adds an Ember/Node compatibility table to the README.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dmcnamara-eng
marked this pull request as ready for review
November 10, 2026 09:32
dmcnamara-eng
requested review from
GavinJoyce,
NullVoxPopuli,
achambers,
alexlafroscia and
mansona
November 10, 2026 09:35
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ember-headlessui can't be used in an app on Ember 7.4.
ember-source@7no longer shipsdist/ember-template-compiler.js, so every v1 addon in our tree that usesember-cli-htmlbars≤ 6 crashes the build:ember-cli-htmlbarsember-element-helperember-cli-htmlbars@6ember-concurrencyember-cli-htmlbars@5; 4.x imports'ember', which Ember 7 removedtracked-maps-and-setstracked-built-ins^4.1.2ember-cli-htmlbars@5ember-cli-babel@babel/core)ember-truth-helpersember-set-helperember-modifierember-auto-import@embroider/macrostracked-built-ins@4usesappEmberSatisfies(added in 1.19)Other changes:
@dropTask/@restartableTaskgenerator methods inmenu.js,transition/applied-class-names.jsandtransition/transition-visibility.jsare rewritten astask({ drop|restartable: true }, async () => {}).index.jsregistersember-concurrency/async-arrow-task-transform.@types/ember__owner, becauseember ts:precompile(prepack) can't read the.ts-extension declarations inember-modifier≥ 4.2. test-app also getsember-auto-import ^2.10and ember-source~4.8.ember-truth-helpers@5. Theember-lts-4.4ember-try scenario and CI job are removed.ember-cli-htmlbars@7. Volta is now pinned to Node 22.22.2 in the root, addon and test-app.Note on CI coverage
The
ember-release/ember-beta/ember-canaryjobs aren't testing those versions. On the latest master run, theember-releasejob's dependency table shows ember-source 4.4.5, because ember-try doesn't actually swapember-sourceinside the pnpm workspace. So CI has never covered Ember 5+. Fixing that is out of scope here, which is why Ember 7.4 was verified by hand (below).Test plan
pnpm installfrom a cleannode_modules, thenpnpm lint: 0 errors (6 pre-existingno-down-event-bindingwarnings).pnpm test(test-app on Ember 4.8.6): 407 tests, 354 pass, 0 fail, 18 skip, 35 todo. The pass/fail counts match master's CI.pnpm pack(runsts:precompile) succeeds.ember-cli@7.3.0Vite/Embroider app withember-source@7.4.0:ember-headlessui@0.17.3: build fails with thetemplateCompilererror above.pnpm packtarball): builds. A rendering test passes 6/6:searchTaskunmountAfterTransitionTask/transitionToHide🤖 Generated with Claude Code