Repository navigation
Fix: add aria-controls to combobox input when open - #213
Merged
dmcnamara-eng merged 1 commit intoOct 16, 2026
Merged
Conversation
An input with role="combobox" must reference the listbox it controls while expanded. The button already sets aria-controls; the input did not, which axe flags as aria-required-attr. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
linds-wmce
changed the title
linds-wmce
marked this pull request as ready for review
October 16, 2026 06:59
Contributor
Author
|
@dmcnamara-eng this is ready for review when you have a chance. I couldn't request you as a reviewer directly since I don't have write access here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Combobox.Inputnow setsaria-controlsto the options listbox id while the combobox is open, and removes it when closed.Why
The input has
role="combobox", so it should reference the listbox it controls when expanded.Combobox.Buttonalready does this witharia-controls={{if @isOpen @guid}}; the input was missing the same attribute. Consumers currently have to patch it in with a custom modifier.Testing
Added an integration test in the
Combobox.Inputmodule that checks the attribute is absent when closed, matches the listbox id when open, and is gone again after closing. All combobox tests pass locally.🤖 Generated with Claude Code