Repository navigation
fix: radio-group tests failing on Ember 4.4 - #210
Closed
dmcnamara-eng wants to merge 1 commit into
Closed
dmcnamara-eng wants to merge 1 commit into
dmcnamara-eng wants to merge 1 commit into
Conversation
Ember 4 removed the implicit this-property fallback in templates, so
bare references like {{onChange}} and {{console.log}} no longer resolve.
Use explicit this.* references and a noop handler instead.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on
masterhas been failing since #209 bumped the test-app to Ember 4.4 (failing run). All 21 failures are inradio-group-test.js.Ember 4 removed the implicit
thisfallback in templates, so bare references in the test templates no longer resolve:{{console.log}}→Attempted to resolve a value in a strict mode template, but that value was not in scope: console{{onChange}},{{setDisabled}},{{isDisabled}},{{value}}→TypeError: block.compile is not a functionFix (test-only):
{{console.log}}with{{this.noop}}, set once in abeforeEach.dialog-test.jsalready uses anoopthe same way.this.to the remaining bare references.Test plan
pnpm --filter test-app run test:ember: 406 tests, 0 failures (353 pass, 18 skip, 35 todo)🤖 Generated with Claude Code