Remove __GFORTRAN__ workarounds, enforce min version#5259
Open
mathomp4 wants to merge 8 commits into
Open
Conversation
Enforce minimum gfortran versions (14.4, 15.2, 16.1) in CMakeLists.txt via a compiler version check, since these were the versions where a gfortran bug preventing direct assignment to derived-type actual results was fixed. With this floor in place, remove the __GFORTRAN__ workaround subroutines in GenericGridComp.F90, StateRegistry_Extensions_smod.F90, and GenericCoupler.F90 in favor of plain assignment. Also remove the dead BUILD_SHARED_MAPL option and MAPL_LIBRARY_TYPE logic, left over from MAPL v2 and no longer used. Fixes #5258
mathomp4
added
0 Diff
mathomp4
marked this pull request as draft
July 15, 2026 19:25
tclune
previously approved these changes
Jul 15, 2026
tclune
left a comment
tclune
left a comment
Collaborator
There was a problem hiding this comment.
Waiting on GCHP acceptance of the change to supported compilers.
Member
Author
And, well, I need to update my spack buildcache for gcc 15 it looks like! ETA: And my gfortran-14 image! On the list for tomorrow... |
mathomp4
added
the
🚫 Contingent - DNA
mathomp4
marked this pull request as ready for review
July 16, 2026 13:48
Member
Author
|
I undrafted because I need to test the CI. So I added a blocking label. I'll re-undraft once I see CI happy |
Member
Author
|
CI looks good. I'll draft again until we have consensus |
mathomp4
marked this pull request as draft
July 17, 2026 17:01
mathomp4
removed
the
🚫 Contingent - DNA
mathomp4
marked this pull request as ready for review
July 24, 2026 13:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of change(s)
Checklist
make testsorctest)Description
Enforces minimum supported gfortran versions (14.4, 15.2, 16.1) in
CMakeLists.txtvia aCMAKE_Fortran_COMPILER_VERSIONcheck, since testing showed gfortran 14.2 still exhibits a compiler bug that prevents direct assignment to derived-type actual results. With this floor in place, removes the__GFORTRAN__-guarded workaround subroutines (nicknamedridiculous) inGenericGridComp.F90,StateRegistry_Extensions_smod.F90, andGenericCoupler.F90in favor of plain assignment.Also removes the dead
BUILD_SHARED_MAPLoption andMAPL_LIBRARY_TYPElogic inCMakeLists.txt, leftover from MAPL v2 and no longer used.Related Issue
Fixes #5258