Repository navigation
Add missing MAPL_Return import in fv_shared - #430
Merged
Merged
Conversation
_RETURN expands to a call to MAPL_Return, which was not in the use-only list, producing an undefined reference at link time. Also apply codee formatting.
pchakraborty
added
bug
mathomp4
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fv_shared.F90uses the_RETURNmacro, which expands to a call toMAPL_Return, butMAPL_Returnwas missing from theuse MAPL, only:list. This produced an unresolved externalmapl_return_(bare name instead of the module-mangled symbol) inlibFVdycoreCubed_GridComp.so, breaking the link ofinterp_restarts.xandrs_scale.x.Changes
MAPL_Returnto theuse MAPL, only:list.