[CHECKSTYLE] [CHORE] Use Constants for time conversions#7370
Open
TechnikTil wants to merge 1 commit intoFunkinCrew:developfrom
Open
[CHECKSTYLE] [CHORE] Use Constants for time conversions#7370TechnikTil wants to merge 1 commit intoFunkinCrew:developfrom
Constants for time conversions#7370TechnikTil wants to merge 1 commit intoFunkinCrew:developfrom
Conversation
Signed-off-by: TechnikTil <techniktil@tilnotdrip.org>
github-actions
bot
added
status: pending triage
Hundrec
added
type: chore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A lot of time conversions in the repository use inline values. This goes against the magic number rule of the repository, so this PR makes sure to replace those values with ones that are in
Constantsto makecheckstylehappy.This PR also adds
Constants.MIN_PER_HOURandConstants.SECS_PER_HOUR. The names are very self explanatory, so I won't elaborate.