[BUGFIX] Pause Dialogue Conversation outro onPause #7359
Open
ahmed7p wants to merge 2 commits intoFunkinCrew:developfrom
Open
[BUGFIX] Pause Dialogue Conversation outro onPause #7359ahmed7p wants to merge 2 commits intoFunkinCrew:developfrom
ahmed7p wants to merge 2 commits intoFunkinCrew:developfrom
Conversation
github-actions
bot
added
pr: haxe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the Dialogue Conversation Outro would continue playing even when the game was paused. The code now ensures that the outro audio and animations properly pause and resume along with the rest of the game state.
Changelog
Created pause() and resume() functions in Conversation.hx to handle both audio and outroTween states.
Updated PlayState.hx to trigger these new functions instead of only pausing the music
Screenshots/Videos
Before
11.04.2026_01.08.02_REC.mp4
After
11.04.2026_01.03.12_REC.mp4