[CRASHFIX] Fix crash when hot-reloading in Lag Adjustment menu#7304
Open
AnimatingLegend wants to merge 1 commit intoFunkinCrew:developfrom
Open
[CRASHFIX] Fix crash when hot-reloading in Lag Adjustment menu#7304AnimatingLegend wants to merge 1 commit intoFunkinCrew:developfrom
AnimatingLegend wants to merge 1 commit intoFunkinCrew:developfrom
Conversation
github-actions
bot
added
size: medium
AnimatingLegend
force-pushed
the
animatinglegend/funkin/patch-9
branch
from
2265574 to
b77bef0
Compare
4 tasks
Hundrec
added
type: major bug
Hundrec
changed the title
|
Yeyy!.. idk what to say lol |
|
Also when your in Offset Calibration the first like 10/9 notes DONT appear. Video: https://www.youtube.com/watch?v=Ez72jmEeoCk. And i think that the offsets are wrong. but in like 0.8.3 (NOT SURE) i did like the offset thing and it was WAYY smaller. not -51 like -17 to -20 there. so.. idk if thats a bug or just my input. but look into that please. |
Contributor
Author
Thats an intentional feature the actual devs added themselves, and i think they have no plans on changing it anytime soon, if not EVER. |
AnimatingLegend
force-pushed
the
animatinglegend/funkin/patch-9
branch
from
b77bef0 to
3b1c7e3
Compare
|
oh okay thx |
AnimatingLegend
force-pushed
the
animatinglegend/funkin/patch-9
branch
3 times, most recently
from
bd8e1cd to
5cd3fda
Compare
Hundrec
force-pushed
the
develop
branch
2 times, most recently
from
2abd802 to
ec59410
Compare
AnimatingLegend
force-pushed
the
animatinglegend/funkin/patch-9
branch
2 times, most recently
from
f7618b0 to
0738497
Compare
github-actions
bot
added
size: tiny
… menu (FunkinCrew#7285) - Added a null check for `FlxG.sound.music` before calling `fadeOut()`. - Created `switchToOffsets()` to avoid duplicating the original code.
AnimatingLegend
force-pushed
the
animatinglegend/funkin/patch-9
branch
from
0738497 to
e228434
Compare
github-actions
bot
added
size: medium
AnimatingLegend
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Description
This PR fixes an obscure crash when hot-reloading in the lag adjustments menu.
Changes:
FlxG.sound.musicbefore callingfadeOut().switchToOffsets()to avoid duplicating the original code.Screenshots/Videos
BEFORE:
lag_adjustment_crash_before.mp4
AFTER:
lag_adjustment_crash_after.mp4