fix(drop): play sound effect when picking up drops#2945
Open
clawctrl1 wants to merge 3 commits into
Open
Conversation
added 3 commits
March 31, 2026 15:15
…ity selected Fixes FreezingMoon#2246 ## Problem When hovering over the active unit, the cursor doesn't change to indicate that the unit is selected but no action is available (no ability selected). ## Solution Added cursor state changes in hex.ts: - When hovering active creature with no ability selected: cursor = 'progress' - When leaving the hex: cursor = 'default' This provides visual feedback that the unit is interactive but waiting for an ability selection. ## Changes - Added cursor 'progress' on onInputOver when hovering active creature - Reset cursor to 'default' on onInputOut Closes FreezingMoon#2246
Fixes FreezingMoon#2363 ## Problem Holding Ctrl+Meta+L in the pre-match screen for too long can result in multiple file picker dialogs opening, causing confusion and potential issues. ## Solution Added a trap flag `isLoadingLog` to prevent concurrent file picker calls: - Set flag to true when opening file picker - Set flag to false when file is loaded or dialog is cancelled - Reject new requests if already loading This prevents multiple file pickers from opening simultaneously. ## Changes - Added `isLoadingLog` flag at module level - Check flag before opening file picker - Reset flag on success, error, or cancel Closes FreezingMoon#2363
Fixes FreezingMoon#1099 ## Problem When a creature picks up a drop, there's no audio feedback, making the action feel less satisfying. ## Solution Added `game.soundsys.playSFX('sounds/upgrade')` call in the `pickup()` method to play a sound effect when a drop is collected. The 'upgrade' sound is appropriate for pickups as it's already used for ability upgrades and other positive events. ## Changes - Added sound effect playback in Drop.pickup() method - Uses existing 'upgrade' sound effect Closes FreezingMoon#1099
|
Someone is attempting to deploy a commit to the FreezingMoon Team on Vercel. A member of the Team first needs to authorize it. |
Author
Audio Feedback for PickupsAdding sound to drop pickups significantly improves the game feel:
The 'upgrade' sound is perfect for this use case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1099
Problem
When a creature picks up a drop, there's no audio feedback, making the action feel less satisfying.
Solution
Added
game.soundsys.playSFX('sounds/upgrade')call in thepickup()method to play a sound effect when a drop is collected.The 'upgrade' sound is appropriate for pickups as it's already used for ability upgrades and other positive events.
Changes
Closes #1099