Repository navigation
Fix decryption with multiple recipients - #42
Merged
Merged
Conversation
supermarin
force-pushed
the
fix-multiple-recipients
branch
2 times, most recently
from
January 23, 2026 18:15
0e46278 to
4cfc769
Compare
Foxboron
reviewed
Jan 24, 2026
Owner
|
This makes sense, thanks for working out a fix! |
supermarin
force-pushed
the
fix-multiple-recipients
branch
2 times, most recently
from
January 24, 2026 16:30
c3a3624 to
6c1d4f6
Compare
supermarin
changed the title
Owner
|
Looks fine, thanks! Please squash the commits and I'll merge and do a release :) |
supermarin
force-pushed
the
fix-multiple-recipients
branch
from
January 24, 2026 16:42
6c1d4f6 to
8f4b770
Compare
Contributor
Author
|
|
Foxboron
approved these changes
Jan 24, 2026
supermarin
force-pushed
the
fix-multiple-recipients
branch
from
January 24, 2026 20:12
8f4b770 to
df652be
Compare
Contributor
Author
Owner
|
Right, the argument order there is iffy and I've made the same mistake myself :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like Identity.Unwrap() was returning too early, i.e. on identity mismatch. The simplest fix was just to check if
err == niland return the filekey. Ended up checking for incorrect identity and propagating errors if there's something else.Fixes #38 #39