Reject IN (SELECT …) subqueries properly as UNSUPPORTED_QUERY - #4595
Open
robert-brunel wants to merge 1 commit into
Open
Reject IN (SELECT …) subqueries properly as UNSUPPORTED_QUERY#4595robert-brunel wants to merge 1 commit into
IN (SELECT …) subqueries properly as UNSUPPORTED_QUERY#4595robert-brunel wants to merge 1 commit into
Conversation
In `AstNormalizer.visitInPredicate()`, add an assert that raises `UNSUPPORTED_QUERY` if the `IN` predicate has a nested `SELECT`, which isn’t supported yet. The same guard already exists in `ExpressionVisitor.visitInPredicate()`, but is effectively unreachable because normalization runs first and as written only handles `expressions()`, which is null in the `IN (SELECT …)` case and prior to this change would trigger a `NullPointerException`.
robert-brunel
force-pushed
the
apple/robert-brunel/antijoin-1
branch
from
September 9, 2026 09:34
d317965 to
9278929
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
AstNormalizer.visitInPredicate(), add an assert that raisesUNSUPPORTED_QUERYif theINpredicate has a nestedSELECT, which isn’t supported yet. The same guard already exists inExpressionVisitor.visitInPredicate(), but is effectively unreachable because normalization runs first and, as written, only handlesexpressions(), which is null in theIN (SELECT …)case and, prior to this change, would trigger aNullPointerException.