Skip to content

port core tests to relational - #4588

Open
normen662 wants to merge 2 commits into
FoundationDB:mainfrom
normen662:port-core-tests-to-relational
Open

port core tests to relational#4588
normen662 wants to merge 2 commits into
FoundationDB:mainfrom
normen662:port-core-tests-to-relational

Conversation

@normen662

Copy link
Copy Markdown
Contributor

No description provided.

@normen662 normen662 added the testing improvement Change that improves our testing label Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

📊 Metrics Diff Analysis Report

Summary

  • New queries: 331
  • Dropped queries: 0
  • Plan changed + metrics changed: 0
  • Plan unchanged + metrics changed: 0
ℹ️ About this analysis

This automated analysis compares query planner metrics between the base branch and this PR. It categorizes changes into:

  • New queries: Queries added in this PR
  • Dropped queries: Queries removed in this PR. These should be reviewed to ensure we are not losing coverage.
  • Plan changed + metrics changed: The query plan has changed along with planner metrics.
  • Metrics only changed: Same plan but different metrics

The last category in particular may indicate planner regressions that should be investigated.

New Queries

Count of new queries by file:

  • yaml-tests/src/test/resources/cascades-query-tests/and-query-to-intersection-choice-unique.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/and-query-to-intersection-choice.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/and-query-to-intersection-compound-pk.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/and-query-to-intersection-num-value-2.metrics.yaml: 2
  • yaml-tests/src/test/resources/cascades-query-tests/and-query-to-intersection-two-covering.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/and-query-to-intersection.metrics.yaml: 3
  • yaml-tests/src/test/resources/cascades-query-tests/covering-index-additional-filter.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/covering-index-concatenated.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/covering-index-header-compound-pk.metrics.yaml: 2
  • yaml-tests/src/test/resources/cascades-query-tests/covering-index-header-concatenated-value.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/covering-index-header-multi.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/covering-index-header-not-covering.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/covering-index-header-value.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/covering-index-multi-value.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/covering-index-multi.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/covering-index-primary-key.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/covering-index.metrics.yaml: 5
  • yaml-tests/src/test/resources/cascades-query-tests/filter-coalescing-multi-index.metrics.yaml: 2
  • yaml-tests/src/test/resources/cascades-query-tests/filter-coalescing.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/group-by-query-aggregate-index.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/group-by-query-both-indexes.metrics.yaml: 5
  • yaml-tests/src/test/resources/cascades-query-tests/group-by-query.metrics.yaml: 2
  • yaml-tests/src/test/resources/cascades-query-tests/in-query-compound-index.metrics.yaml: 2
  • yaml-tests/src/test/resources/cascades-query-tests/in-query-header.metrics.yaml: 3
  • yaml-tests/src/test/resources/cascades-query-tests/in-query-multi-index.metrics.yaml: 10
  • yaml-tests/src/test/resources/cascades-query-tests/in-query-or-compound.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/in-query-or.metrics.yaml: 5
  • yaml-tests/src/test/resources/cascades-query-tests/in-query-sorted-extra-unordered-columns.metrics.yaml: 4
  • yaml-tests/src/test/resources/cascades-query-tests/in-query-union-intersection-no-nv3.metrics.yaml: 3
  • yaml-tests/src/test/resources/cascades-query-tests/in-query-union-intersection.metrics.yaml: 3
  • yaml-tests/src/test/resources/cascades-query-tests/in-query-union-sargable.metrics.yaml: 3
  • yaml-tests/src/test/resources/cascades-query-tests/in-query.metrics.yaml: 8
  • yaml-tests/src/test/resources/cascades-query-tests/long-arithmetic-functions-binary.metrics.yaml: 16
  • yaml-tests/src/test/resources/cascades-query-tests/long-arithmetic-functions-complex.metrics.yaml: 3
  • yaml-tests/src/test/resources/cascades-query-tests/long-arithmetic-functions-mask-1.metrics.yaml: 3
  • yaml-tests/src/test/resources/cascades-query-tests/long-arithmetic-functions-mask-2.metrics.yaml: 3
  • yaml-tests/src/test/resources/cascades-query-tests/long-arithmetic-functions-two-column.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/long-arithmetic-functions-unique-mask-4.metrics.yaml: 9
  • yaml-tests/src/test/resources/cascades-query-tests/long-arithmetic-functions.metrics.yaml: 12
  • yaml-tests/src/test/resources/cascades-query-tests/modification-query.metrics.yaml: 12
  • yaml-tests/src/test/resources/cascades-query-tests/multi-field-index-selection-prefix-scalar.metrics.yaml: 2
  • yaml-tests/src/test/resources/cascades-query-tests/multi-field-index-selection-wider-covering.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/multi-field-index-selection.metrics.yaml: 5
  • yaml-tests/src/test/resources/cascades-query-tests/nested-field-query-complex.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/nested-field-query-concat-nested.metrics.yaml: 3
  • yaml-tests/src/test/resources/cascades-query-tests/nested-field-query-hierarchical.metrics.yaml: 2
  • yaml-tests/src/test/resources/cascades-query-tests/nested-field-query-nested-map.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/nested-field-query-nested-pk.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/nested-field-query-reviewer-between.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/nested-field-query-reviewer-email-hometown.metrics.yaml: 2
  • yaml-tests/src/test/resources/cascades-query-tests/nested-field-query-reviewer-hometown-email.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/nested-field-query-reviewer-school-concat.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/nested-field-query-reviewer-sorted-inequality.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/nested-field-query-reviewer-sorted.metrics.yaml: 4
  • yaml-tests/src/test/resources/cascades-query-tests/nested-field-query-reviewer.metrics.yaml: 2
  • yaml-tests/src/test/resources/cascades-query-tests/nested-field-query.metrics.yaml: 3
  • yaml-tests/src/test/resources/cascades-query-tests/or-query-to-union-compound-pk-ordered.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/or-query-to-union-compound-pk.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/or-query-to-union-covering.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/or-query-to-union-key-with-value.metrics.yaml: 4
  • yaml-tests/src/test/resources/cascades-query-tests/or-query-to-union-nested-predicates.metrics.yaml: 4
  • yaml-tests/src/test/resources/cascades-query-tests/or-query-to-union-no-index.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/or-query-to-union-ordered-and.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/or-query-to-union-ordered.metrics.yaml: 8
  • yaml-tests/src/test/resources/cascades-query-tests/or-query-to-union-proto-only.metrics.yaml: 2
  • yaml-tests/src/test/resources/cascades-query-tests/or-query-to-union-split-continuations.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/or-query-to-union-str-3-index.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/or-query-to-union-unorderable-and.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/or-query-to-union.metrics.yaml: 8
  • yaml-tests/src/test/resources/cascades-query-tests/ordering-query-two-indexes.metrics.yaml: 2
  • yaml-tests/src/test/resources/cascades-query-tests/ordering-query.metrics.yaml: 2
  • yaml-tests/src/test/resources/cascades-query-tests/permuted-min-max-num-value-2.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/permuted-min-max-ordering-keys.metrics.yaml: 4
  • yaml-tests/src/test/resources/cascades-query-tests/permuted-min-max-repeater.metrics.yaml: 4
  • yaml-tests/src/test/resources/cascades-query-tests/permuted-min-max-str-value.metrics.yaml: 5
  • yaml-tests/src/test/resources/cascades-query-tests/permuted-min-max.metrics.yaml: 16
  • yaml-tests/src/test/resources/cascades-query-tests/record-store-query-continuation.metrics.yaml: 3
  • yaml-tests/src/test/resources/cascades-query-tests/record-store-query-even-odd.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/record-store-query-exclude-null.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/record-store-query-null.metrics.yaml: 2
  • yaml-tests/src/test/resources/cascades-query-tests/record-store-query.metrics.yaml: 3
  • yaml-tests/src/test/resources/cascades-query-tests/record-store-repeated-query-sum-by-repeated.metrics.yaml: 2
  • yaml-tests/src/test/resources/cascades-query-tests/record-store-repeated-query.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/record-type-key.metrics.yaml: 3
  • yaml-tests/src/test/resources/cascades-query-tests/recursive-queries-forest.metrics.yaml: 4
  • yaml-tests/src/test/resources/cascades-query-tests/recursive-queries-multiples.metrics.yaml: 8
  • yaml-tests/src/test/resources/cascades-query-tests/recursive-queries.metrics.yaml: 24
  • yaml-tests/src/test/resources/cascades-query-tests/repeated-field-query-only-index.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/repeated-field-query-prefix-repeated-nested.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/repeated-field-query-prefix-repeated.metrics.yaml: 2
  • yaml-tests/src/test/resources/cascades-query-tests/repeated-field-query.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/restricted-index-disabled.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/restricted-index-write-only.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/returned-record-limit-no-filter.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/returned-record-limit.metrics.yaml: 2
  • yaml-tests/src/test/resources/cascades-query-tests/simple-query-graph-hints.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/simple-query-graph-joins.metrics.yaml: 3
  • yaml-tests/src/test/resources/cascades-query-tests/simple-query-graph-name-tag-index.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/simple-query-graph-tag-index.metrics.yaml: 2
  • yaml-tests/src/test/resources/cascades-query-tests/simple-query-graph.metrics.yaml: 2
  • yaml-tests/src/test/resources/cascades-query-tests/sort-index-selection-nested.metrics.yaml: 6
  • yaml-tests/src/test/resources/cascades-query-tests/sort-index-selection-primary-key.metrics.yaml: 2
  • yaml-tests/src/test/resources/cascades-query-tests/sort-index-selection-unique.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/sort-index-selection.metrics.yaml: 4
  • yaml-tests/src/test/resources/cascades-query-tests/sparse-index-implied.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/sparse-index-not-implied.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/sparse-index-or-predicate.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/versions-query-long-record.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/versions-query-other-record.metrics.yaml: 1
  • yaml-tests/src/test/resources/cascades-query-tests/versions-query.metrics.yaml: 6

@alecgrieser alecgrieser added the DO NOT MERGE do not merge label Sep 9, 2026
@alecgrieser

Copy link
Copy Markdown
Collaborator

Adding DO NOT MERGE do not merge as the plan job fails to resolve all of the files correctly, which means that we don't actually run the tests. We'll need to address that before merging, either by shrinking the PR or fixing the plan job to handle this many files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE do not merge testing improvement Change that improves our testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants